Skip to content

Fix bug in contract caller #1552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2019
Merged

Fix bug in contract caller #1552

merged 1 commit into from
Dec 12, 2019

Conversation

@njgheorghita
Copy link
Contributor

@njgheorghita njgheorghita commented Dec 12, 2019 •
edited
Loading

What was wrong?

Minor bug in ContractCaller fn lookup.

Todo:

Cute Animal Picture

image

@njgheorghita njgheorghita requested a review from kclowes December 12, 2019 14:10
kclowes
kclowes approved these changes Dec 12, 2019
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch! 🎣

@njgheorghita njgheorghita merged commit f5fcaa6 into ethereum:master Dec 12, 2019
@njgheorghita njgheorghita deleted the bugfix branch December 12, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kclowes kclowes kclowes approved these changes

@pipermerriam pipermerriam Awaiting requested review from pipermerriam

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@njgheorghita @kclowes