Skip to content

Fix SyntaxWarning #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 14, 2019
Merged

Fix SyntaxWarning #1498

merged 3 commits into from
Nov 14, 2019

Conversation

@Fedalto
Copy link
Contributor

@Fedalto Fedalto commented Nov 11, 2019 •
edited by kclowes
Loading

What was wrong?

Python is complaining with a SyntaxWarning when comparing with literals using is/is not

is and is not are identity operators, that check if they are the
same objects, which is not what we want when comparing on these cases.

How was it fixed?

Change to use == and != where appropriate

Todo:

Cute Animal Picture

@Fedalto
Fix SyntaxWarning
2711ed9 
`is` and `is not` are identity operators, that check if they are the
same objects, which is not what we want when comparing on these cases.
Change to use the equality operators `==` and `!=`
@Fedalto
Copy link
Contributor Author

Fedalto commented Nov 11, 2019 •
edited
Loading

The CI is failing with this change, which probably mean that it have uncovered a test that was passing before when it should be failing.
But I don't have the context to know how to fix it.

@kclowes
Copy link
Collaborator

kclowes commented Nov 11, 2019

Thanks @Fedalto. It looks like a bug to me too. I'll take a look!

kclowes
kclowes approved these changes Nov 14, 2019
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Fedalto! Turns out the maxMessageSize and the minPow was still set from the test before.

@kclowes kclowes merged commit c3be0f9 into ethereum:master Nov 14, 2019
@Fedalto Fedalto deleted the fix_syntax_warnings branch November 17, 2019 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kclowes kclowes kclowes approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Fedalto @kclowes