Skip to content

Commit e83486d

Browse files
committed
Improve addReservedPeer test
1 parent eee3c65 commit e83486d

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

web3/_utils/module_testing/parity_module.py

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -91,13 +91,7 @@ def test_trace_filter(self, web3, txn_filter_params, parity_fixture_data):
9191
trace = web3.parity.traceFilter(txn_filter_params)
9292
assert isinstance(trace, list)
9393
assert trace[0]['action']['from'] == add_0x_prefix(parity_fixture_data['coinbase'])
94-
95-
96-
@pytest.mark.parametrize(
97-
'params',
98-
['enode://f1a6b0bdbf014355587c3018454d070ac57801f05d3b39fe85da574f002a32e929f683d72aa5a8318382e4d3c7a05c9b91687b0d997a39619fb8a6e7ad88e512@1.1.1.1:30300']
99-
)
100-
def test_add_reserved_peer(self, web3, params):
101-
response = web3.parity.addReservedPeer([params])
102-
assert response["result"]==True
103-
94+
95+
def test_add_reserved_peer(self, web3):
96+
peer_addr = 'enode://f1a6b0bdbf014355587c3018454d070ac57801f05d3b39fe85da574f002a32e929f683d72aa5a8318382e4d3c7a05c9b91687b0d997a39619fb8a6e7ad88e512@1.1.1.1:30300' # noqa: E501
97+
assert web3.parity.addReservedPeer(peer_addr)

web3/parity.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,10 @@ def netPeers(self):
8383
[],
8484
)
8585

86-
def addReservedPeer(self, params):
86+
def addReservedPeer(self, url):
8787
return self.web3.manager.request_blocking(
8888
"parity_addReservedPeer",
89-
params,
89+
[url],
9090
)
9191

9292
def traceReplayTransaction(self, transaction_hash, mode=['trace']):

0 commit comments

Comments
 (0)