Skip to content

Commit e0579d4

Browse files
committed
Add condition to check for secret key and return correct uri
1 parent f55f563 commit e0579d4

File tree

3 files changed

+14
-4
lines changed

3 files changed

+14
-4
lines changed

.circleci/config.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,6 @@ jobs:
181181
TOXENV: py36-ethpm
182182
# Please don't use this key for any shenanigans
183183
WEB3_INFURA_PROJECT_ID: 7707850c2fb7465ebe6f150d67182e22
184-
WEB3_INFURA_API_SECRET: 1955838f22ac4d858434f41498557130
185184

186185
py36-integration-goethereum-ipc-1.7.2:
187186
<<: *geth_steps
@@ -290,7 +289,6 @@ jobs:
290289
TOXENV: py37-ethpm
291290
# Please don't use this key for any shenanigans
292291
WEB3_INFURA_PROJECT_ID: 7707850c2fb7465ebe6f150d67182e22
293-
WEB3_INFURA_API_SECRET: 1955838f22ac4d858434f41498557130
294292

295293
py37-integration-goethereum-ipc-1.7.2:
296294
<<: *geth_steps
@@ -399,7 +397,6 @@ jobs:
399397
TOXENV: py38-ethpm
400398
# Please don't use this key for any shenanigans
401399
WEB3_INFURA_PROJECT_ID: 7707850c2fb7465ebe6f150d67182e22
402-
WEB3_INFURA_API_SECRET: 1955838f22ac4d858434f41498557130
403400

404401
py38-integration-goethereum-ipc-1.7.2:
405402
<<: *geth_steps

tests/core/providers/test_auto_provider.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,17 @@ def test_web3_auto_infura_websocket_with_secret(monkeypatch, caplog, environ_nam
139139
assert getattr(w3.provider, 'endpoint_uri') == expected_url
140140

141141

142+
def test_web3_auto_infura_websocket_without_secret(monkeypatch):
143+
monkeypatch.setenv('WEB3_INFURA_PROJECT_ID', 'test')
144+
145+
importlib.reload(infura)
146+
147+
w3 = infura.w3
148+
assert isinstance(w3.provider, WebsocketProvider)
149+
expected_url = 'wss://%s/ws/v3/test' % (infura.INFURA_MAINNET_DOMAIN)
150+
assert getattr(w3.provider, 'endpoint_uri') == expected_url
151+
152+
142153
@pytest.mark.parametrize('environ_name', ['WEB3_INFURA_API_KEY', 'WEB3_INFURA_PROJECT_ID'])
143154
def test_web3_auto_infura_with_secret(monkeypatch, caplog, environ_name):
144155
monkeypatch.setenv('WEB3_INFURA_SCHEME', 'https')

web3/auto/infura/endpoints.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,10 @@ def build_infura_url(domain):
4646
key = load_api_key()
4747
secret = load_secret()
4848

49-
if scheme == WEBSOCKET_SCHEME:
49+
if scheme == WEBSOCKET_SCHEME and secret != '':
5050
return "%s://:%s@%s/ws/v3/%s" % (scheme, secret, domain, key)
51+
elif scheme == WEBSOCKET_SCHEME and secret == '':
52+
return "%s://%s/ws/v3/%s" % (scheme, domain, key)
5153
elif scheme == HTTP_SCHEME:
5254
return "%s://%s/v3/%s" % (scheme, domain, key)
5355
else:

0 commit comments

Comments
 (0)