Add web3.eth.signTransaction test to integration tests

Author: njgheorghita

tests/integration/go_ethereum/common.py

@@ -8,6 +8,8 @@
     Web3ModuleTest,
 )
 
+GETH_EXPECTED = b'\xf8j\x80\x85\x040\xe24\x00\x82R\x08\x94\xdcTM\x1a\xa8\x8f\xf8\xbb\xd2\xf2\xae\xc7T\xb1\xf1\xe9\x9e\x18\x12\xfd\x01\x80\x86\xee\xca\xc4f\xe1\x16\xa0\xbb7^\x1f\xf0\x03(P\x07|\x053Q\xd3M\xf1\x83\xe9\xdcp\xdc\x02\xb4\xe7`\x85\xcd\x84\xdb\xb4\xd0\xaa\xa07\x8cl\xd7\xa6R\x01\xfaW\x0e\x0f\xc1_$\xdf`\x8dO\x18\x1dC\xbc\x87\x8fud\xd2R*W\xfd4'  # noqa: E501
+
 
 class GoEthereumTest(Web3ModuleTest):
     def _check_web3_clientVersion(self, client_version):
@@ -59,6 +61,9 @@ def test_eth_estimateGas_with_block(self,
             web3, unlocked_account_dual_type
         )
 
+    def test_eth_signTransaction(self, web3, unlocked_account):
+        super().test_eth_signTransaction(web3, unlocked_account, GETH_EXPECTED)
+
 
 class GoEthereumVersionModuleTest(VersionModuleTest):
     pass

tests/integration/test_ethereum_tester.py

@@ -216,6 +216,7 @@ def func_wrapper(self, eth_tester, *args, **kwargs):
 
 class TestEthereumTesterEthModule(EthModuleTest):
     test_eth_sign = not_implemented(EthModuleTest.test_eth_sign, ValueError)
+    test_eth_signTransaction = not_implemented(EthModuleTest.test_eth_signTransaction, ValueError)
 
     @disable_auto_mine
     def test_eth_getTransactionReceipt_unmined(self, eth_tester, web3, unlocked_account):

web3/_utils/module_testing/eth_module.py

@@ -196,6 +196,23 @@ def test_eth_sign(self, web3, unlocked_account_dual_type):
         )
         assert new_signature != signature
 
+    def test_eth_signTransaction(self, web3, unlocked_account, geth_expected=None):
+        txn_params = {
+            'from': unlocked_account,
+            'to': unlocked_account,
+            'value': 1,
+            'gas': 21000,
+            'gasPrice': web3.eth.gasPrice,
+            'nonce': 0,
+        }
+        COINBASE_PK = '0x58d23b55bc9cdce1f18c2500f40ff4ab7245df9a89505e9b1fa4851f623d241d'
+        result = web3.eth.signTransaction(txn_params)
+        actual = web3.eth.account.signTransaction(txn_params, COINBASE_PK)
+        if geth_expected:
+            assert result['raw'] == geth_expected
+        else:
+            assert result['raw'] == actual.rawTransaction
+
     def test_eth_sendTransaction_addr_checksum_required(self, web3, unlocked_account):
         non_checksum_addr = unlocked_account.lower()
         txn_params = {

web3/_utils/rpc_abi.py

@@ -50,6 +50,7 @@
     'eth_newFilter': FILTER_PARAMS_ABIS,
     'eth_sendRawTransaction': ['bytes'],
     'eth_sendTransaction': TRANSACTION_PARAMS_ABIS,
+    'eth_signTransaction': TRANSACTION_PARAMS_ABIS,
     'eth_sign': ['address', 'bytes'],
     # personal
     'personal_sendTransaction': TRANSACTION_PARAMS_ABIS,

web3/eth.py

@@ -311,6 +311,11 @@ def sign(self, account, data=None, hexstr=None, text=None):
             "eth_sign", [account, message_hex],
         )
 
+    def signTransaction(self, transaction):
+        return self.web3.manager.request_blocking(
+            "eth_signTransaction", [transaction],
+        )
+
     @apply_to_return_value(HexBytes)
     def call(self, transaction, block_identifier=None):
         # TODO: move to middleware

web3/middleware/pythonic.py

@@ -109,6 +109,15 @@ def to_hexbytes(num_bytes, val, variable_length=False):
 transaction_formatter = apply_formatters_to_dict(TRANSACTION_FORMATTERS)
 
 
+SIGNED_TX_FORMATTER = {
+    'raw': HexBytes,
+    'tx': transaction_formatter,
+}
+
+
+signed_tx_formatter = apply_formatters_to_dict(SIGNED_TX_FORMATTER)
+
+
 WHISPER_LOG_FORMATTERS = {
     'sig': to_hexbytes(130),
     'topic': to_hexbytes(8),
@@ -344,6 +353,7 @@ def to_hexbytes(num_bytes, val, variable_length=False):
         ),
         'eth_sendRawTransaction': to_hexbytes(32),
         'eth_sendTransaction': to_hexbytes(32),
+        'eth_signTransaction': apply_formatter_if(is_not_null, signed_tx_formatter),
         'eth_sign': HexBytes,
         'eth_syncing': apply_formatter_if(is_not_false, syncing_formatter),
         # personal

web3/providers/eth_tester/defaults.py

@@ -201,6 +201,7 @@ def personal_send_transaction(eth_tester, params):
         )),
         'getCode': call_eth_tester('get_code'),
         'sign': not_implemented,
+        'signTransaction': not_implemented,
         'sendTransaction': call_eth_tester('send_transaction'),
         'sendRawTransaction': call_eth_tester('send_raw_transaction'),
         'call': call_eth_tester('call'),  # TODO: untested