In case request_timeout is None, use 0, where relevant

Author: fselmo

tests/core/utilities/test_http_session_manager.py

@@ -75,7 +75,7 @@ def _simulate_call(http_session_manager, uri):
     return _session
 
 
-@pytest.fixture
+@pytest.fixture(scope="function")
 def http_session_manager():
     return HTTPSessionManager()
 
@@ -323,7 +323,6 @@ async def test_session_manager_async_cache_does_not_close_session_before_a_call_
     # set cache size to 1 + set future session close thread time to 0.01s
     http_session_manager.session_cache = SimpleCache(1)
     _timeout_for_testing = 0.01
-    http_session_manager.request_timeout = _timeout_for_testing
 
     async def cache_uri_and_return_session(uri):
         _session = await http_session_manager.async_cache_and_return_session(

web3/_utils/http_session_manager.py

@@ -86,7 +86,7 @@ def cache_and_return_session(
                     f"{evicted_session}",
                 )
             threading.Timer(
-                request_timeout + 0.1,
+                request_timeout or 0 + 1,
                 self._close_evicted_sessions,
                 args=[evicted_sessions],
             ).start()
@@ -209,11 +209,11 @@ async def async_cache_and_return_session(
             # Kick off a future task, in a separate thread, to close the evicted
             # sessions. In the case that the cache filled very quickly and some
             # sessions have been evicted before their original request has been made,
-            # we set the timer to a bit more than the `DEFAULT_TIMEOUT` for a call. This
+            # we set the timer to a bit more than the `request_timeout` for a call. This
             # should make it so that any call from an evicted session can still be made
             # before the session is closed.
             threading.Timer(
-                request_timeout.total + 0.1,
+                request_timeout.total or 0 + 1,
                 self._async_close_evicted_sessions,
                 args=[evicted_sessions],
             ).start()