Add formatter for data field for transaction results

- Nethermind returns both ``data`` and ``input`` with the same value for each. Add a formatter for ``data`` that will format the field if it is present.
- Add a test for transaction result formatters via ``eth.get_transaction()`` test.

Author: fselmo

newsfragments/3129.misc.rst

@@ -0,0 +1 @@
+Add transaction result formatter for ``data`` field. Nethermind, for example, returns both ``data`` and ``input`` for transaction results.

tests/core/eth-module/test_transactions.py

@@ -1,14 +1,31 @@
 import pytest
 
+from eth_utils import (
+    to_checksum_address,
+    to_int,
+)
+from hexbytes import (
+    HexBytes,
+)
+
 from web3._utils.ens import (
     ens_addresses,
 )
+from web3._utils.rpc_abi import (
+    RPC,
+)
+from web3.datastructures import (
+    AttributeDict,
+)
 from web3.exceptions import (
     NameNotFound,
     TimeExhausted,
     TransactionNotFound,
     Web3ValidationError,
 )
+from web3.middleware import (
+    construct_result_generator_middleware,
+)
 from web3.middleware.simulate_unmined_transaction import (
     unmined_receipt_simulator_middleware,
 )
@@ -174,3 +191,102 @@ def test_unmined_transaction_wait_for_receipt(w3):
     txn_receipt = w3.eth.wait_for_transaction_receipt(txn_hash)
     assert txn_receipt["transactionHash"] == txn_hash
     assert txn_receipt["blockHash"] is not None
+
+
+def test_get_transaction_formatters(w3):
+    non_checksummed_addr = "0xB2930B35844A230F00E51431ACAE96FE543A0347"  # all uppercase
+    unformatted_transaction = {
+        "blockHash": (
+            "0x849044202a39ae36888481f90d62c3826bca8269c2716d7a38696b4f45e61d83"
+        ),
+        "blockNumber": "0x1b4",
+        "transactionIndex": "0x0",
+        "nonce": "0x0",
+        "gas": "0x4c4b40",
+        "gasPrice": "0x1",
+        "maxFeePerGas": "0x1",
+        "maxPriorityFeePerGas": "0x1",
+        "value": "0x1",
+        "from": non_checksummed_addr,
+        "publicKey": "0x",
+        "r": "0xd148ae70c8cbef3a038e70e6d1639f0951e60a2965820f33bad19d0a6c2b8116",
+        "raw": "0x142ab034696c09dcfb2a8b086b494f3f4c419e67b6c04d95882f87156a3b6f35",
+        "s": "0x6f5216fc207221a11efe2e4c3e3a881a0b5ca286ede538fc9dbc403b2009ea76",
+        "to": non_checksummed_addr,
+        "hash": "0x142ab034696c09dcfb2a8b086b494f3f4c419e67b6c04d95882f87156a3b6f35",
+        "v": "0x1",
+        "yParity": "0x1",
+        "standardV": "0x1",
+        "type": "0x2",
+        "chainId": "0x539",
+        "accessList": [
+            {
+                "address": non_checksummed_addr,
+                "storageKeys": [
+                    "0x0000000000000000000000000000000000000000000000000000000000000032",  # noqa: E501
+                    "0x0000000000000000000000000000000000000000000000000000000000000036",  # noqa: E501
+                ],
+            },
+            {
+                "address": non_checksummed_addr,
+                "storageKeys": [],
+            },
+        ],
+        "input": "0x5b34b966",
+        "data": "0x5b34b966",
+    }
+
+    result_middleware = construct_result_generator_middleware(
+        {
+            RPC.eth_getTransactionByHash: lambda *_: unformatted_transaction,
+        }
+    )
+    w3.middleware_onion.inject(result_middleware, "result_middleware", layer=0)
+    received_block = w3.eth.get_transaction("")
+
+    expected = AttributeDict(
+        {
+            "blockHash": HexBytes(unformatted_transaction["blockHash"]),
+            "blockNumber": to_int(hexstr=unformatted_transaction["blockNumber"]),
+            "transactionIndex": 0,
+            "nonce": 0,
+            "gas": to_int(hexstr=unformatted_transaction["gas"]),
+            "gasPrice": 1,
+            "maxFeePerGas": 1,
+            "maxPriorityFeePerGas": 1,
+            "value": 1,
+            "from": to_checksum_address(non_checksummed_addr),
+            "publicKey": HexBytes(unformatted_transaction["publicKey"]),
+            "r": HexBytes(unformatted_transaction["r"]),
+            "raw": HexBytes(unformatted_transaction["raw"]),
+            "s": HexBytes(unformatted_transaction["s"]),
+            "to": to_checksum_address(non_checksummed_addr),
+            "hash": HexBytes(unformatted_transaction["hash"]),
+            "v": 1,
+            "yParity": 1,
+            "standardV": 1,
+            "type": 2,
+            "chainId": 1337,
+            "accessList": [
+                AttributeDict(
+                    {
+                        "address": to_checksum_address(non_checksummed_addr),
+                        "storageKeys": [
+                            "0x0000000000000000000000000000000000000000000000000000000000000032",  # noqa: E501
+                            "0x0000000000000000000000000000000000000000000000000000000000000036",  # noqa: E501
+                        ],
+                    }
+                ),
+                AttributeDict(
+                    {
+                        "address": to_checksum_address(non_checksummed_addr),
+                        "storageKeys": [],
+                    }
+                ),
+            ],
+            "input": HexBytes(unformatted_transaction["input"]),
+            "data": HexBytes(unformatted_transaction["data"]),
+        }
+    )
+    assert received_block == expected
+    w3.middleware_onion.remove("result_middleware")

web3/_utils/method_formatters.py

@@ -219,6 +219,7 @@ def type_aware_apply_formatters_to_dict_keys_and_values(
         ),
     ),
     "input": HexBytes,
+    "data": HexBytes,  # Nethermind, for example, returns both `input` and `data`
 }