move ethpm deprecation warning to only show when enabled

pacrob · pacrob · commit 52e0ce5998e9 · 2023-06-06T15:58:28.000-06:00
diff --git a/ethpm/__init__.py b/ethpm/__init__.py
@@ -1,13 +1,6 @@
-import warnings
 from pathlib import Path
 
 
-warnings.warn(
-    "The ``ethPM`` module is no longer being maintained and will be "
-    "deprecated with ``web3.py`` version 7",
-    UserWarning,
-)
-
 ETHPM_DIR = Path(__file__).parent
 ASSETS_DIR = ETHPM_DIR / "assets"
 
diff --git a/newsfragments/2930.internal.rst b/newsfragments/2930.internal.rst
@@ -1 +1 @@
-`lint-roll` - dropped `isort` `--recursive` flag, not needed as of their `v5`, added black
+``lint-roll`` - dropped ``isort`` ``--recursive`` flag, not needed as of their ``v5``, added black
diff --git a/newsfragments/2960.docs.rst b/newsfragments/2960.docs.rst
@@ -1 +1 @@
-Completed docstrings for `ContractFunction` and `AsyncContractFunction` classes
+Completed docstrings for ``ContractFunction`` and ``AsyncContractFunction`` classes
diff --git a/newsfragments/2961.docs.rst b/newsfragments/2961.docs.rst
@@ -1 +1 @@
-Added 'unsupported by any current clients' note to the `Eth.sign_typed_data` docs
+Added 'unsupported by any current clients' note to the ``Eth.sign_typed_data`` docs
diff --git a/newsfragments/2962.docs.rst b/newsfragments/2962.docs.rst
@@ -1 +1 @@
-Removed list of `AsyncHTTPProvider`-supported methods, it supports them all now
+Removed list of ``AsyncHTTPProvider``-supported methods, it supports them all now
diff --git a/newsfragments/2971.docs.rst b/newsfragments/2971.docs.rst
@@ -1 +1 @@
-Removed references to defunct providers in `IPCProvider` docs
+Removed references to defunct providers in ``IPCProvider`` docs
diff --git a/newsfragments/2983.internal.rst b/newsfragments/2983.internal.rst
@@ -0,0 +1 @@
+Moved ``ethpm`` deprecation warning to only show when the module is explicitly enabled
diff --git a/web3/main.py b/web3/main.py
@@ -1,4 +1,5 @@
 import decimal
+import warnings
 
 from ens import (
     AsyncENS,
@@ -343,9 +344,14 @@ def pm(self) -> "PM":
             )
 
     def enable_unstable_package_management_api(self) -> None:
-        from web3.pm import PM  # noqa: F811
-
         if not hasattr(self, "_pm"):
+            warnings.warn(
+                "The ``ethPM`` module is no longer being maintained and will be "
+                "deprecated with ``web3.py`` version 7",
+                UserWarning,
+            )
+            from web3.pm import PM  # noqa: F811
+
             self.attach_modules({"_pm": PM})
 
 

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		-`lint-roll` - dropped `isort` `--recursive` flag, not needed as of their `v5`, added black
	`1`	+``lint-roll`` - dropped ``isort`` ``--recursive`` flag, not needed as of their ``v5``, added black
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		-Completed docstrings for `ContractFunction` and `AsyncContractFunction` classes
	`1`	+Completed docstrings for ``ContractFunction`` and ``AsyncContractFunction`` classes
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		-Added 'unsupported by any current clients' note to the `Eth.sign_typed_data` docs
	`1`	+Added 'unsupported by any current clients' note to the ``Eth.sign_typed_data`` docs
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		-Removed list of `AsyncHTTPProvider`-supported methods, it supports them all now
	`1`	+Removed list of ``AsyncHTTPProvider``-supported methods, it supports them all now
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		-Removed references to defunct providers in `IPCProvider` docs
	`1`	+Removed references to defunct providers in ``IPCProvider`` docs
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Moved ``ethpm`` deprecation warning to only show when the module is explicitly enabled