Add @flaky to tests that expect mining at certain times

- This isn't ideal. Perhaps we can increase the ``dev.period`` (mining
  interval) to make these tests a bit more reliable and hopefully
  the other tests are unaffected.

Author: fselmo

web3/_utils/module_testing/eth_module.py

@@ -195,6 +195,7 @@ async def test_eth_send_transaction_legacy(
         assert txn["gas"] == 21000
         assert txn["gasPrice"] == txn_params["gasPrice"]
 
+    @flaky(max_runs=3)
     @pytest.mark.asyncio
     async def test_eth_modify_transaction_legacy(
         self, async_w3: "AsyncWeb3", async_unlocked_account: ChecksumAddress
@@ -225,6 +226,7 @@ async def test_eth_modify_transaction_legacy(
         assert modified_txn["gas"] == 21000
         assert modified_txn["gasPrice"] == cast(int, txn_params["gasPrice"]) * 2
 
+    @flaky(max_runs=3)
     @pytest.mark.asyncio
     async def test_eth_modify_transaction(
         self, async_w3: "AsyncWeb3", async_unlocked_account: ChecksumAddress
@@ -2073,6 +2075,7 @@ async def test_async_eth_sign_ens_names(
             assert is_bytes(signature)
             assert len(signature) == 32 + 32 + 1
 
+    @flaky(max_runs=3)
     @pytest.mark.asyncio
     async def test_async_eth_replace_transaction_legacy(
         self, async_w3: "AsyncWeb3", async_unlocked_account_dual_type: ChecksumAddress
@@ -2082,9 +2085,7 @@ async def test_async_eth_replace_transaction_legacy(
             "to": async_unlocked_account_dual_type,
             "value": Wei(1),
             "gas": 21000,
-            "gasPrice": async_w3.to_wei(
-                1, "gwei"
-            ),  # must be greater than base_fee post London
+            "gasPrice": async_w3.to_wei(1, "gwei"),
         }
         txn_hash = await async_w3.eth.send_transaction(txn_params)
 
@@ -2102,6 +2103,7 @@ async def test_async_eth_replace_transaction_legacy(
         assert replace_txn["gas"] == 21000
         assert replace_txn["gasPrice"] == txn_params["gasPrice"]
 
+    @flaky(max_runs=3)
     @pytest.mark.asyncio
     async def test_async_eth_replace_transaction(
         self, async_w3: "AsyncWeb3", async_unlocked_account_dual_type: ChecksumAddress
@@ -2136,6 +2138,7 @@ async def test_async_eth_replace_transaction(
         assert replace_txn["maxFeePerGas"] == three_gwei_in_wei
         assert replace_txn["maxPriorityFeePerGas"] == two_gwei_in_wei
 
+    @flaky(max_runs=3)
     @pytest.mark.asyncio
     async def test_async_eth_replace_transaction_underpriced(
         self, async_w3: "AsyncWeb3", async_unlocked_account_dual_type: ChecksumAddress
@@ -2258,6 +2261,7 @@ async def test_async_eth_replace_transaction_gas_price_defaulting_minimum(
             gas_price * 1.125
         )  # minimum gas price
 
+    @flaky(max_runs=3)
     @pytest.mark.asyncio
     async def test_async_eth_replace_transaction_gas_price_defaulting_strategy_higher(
         self, async_w3: "AsyncWeb3", async_unlocked_account: ChecksumAddress
@@ -2286,6 +2290,7 @@ def higher_gas_price_strategy(async_w3: "AsyncWeb3", txn: TxParams) -> Wei:
         )  # Strategy provides higher gas price
         async_w3.eth.set_gas_price_strategy(None)  # reset strategy
 
+    @flaky(max_runs=3)
     @pytest.mark.asyncio
     async def test_async_eth_replace_transaction_gas_price_defaulting_strategy_lower(
         self, async_w3: "AsyncWeb3", async_unlocked_account: ChecksumAddress
@@ -2335,7 +2340,6 @@ async def test_async_eth_new_block_filter(self, async_w3: "AsyncWeb3") -> None:
 
         changes = await async_w3.eth.get_filter_changes(filter.filter_id)
         assert is_list_like(changes)
-        assert not changes
 
         result = await async_w3.eth.uninstall_filter(filter.filter_id)
         assert result is True
@@ -2999,6 +3003,7 @@ def test_eth_send_transaction(
         assert txn["maxPriorityFeePerGas"] == txn_params["maxPriorityFeePerGas"]
         assert txn["gasPrice"] == txn_params["maxFeePerGas"]
 
+    @flaky(max_runs=3)
     def test_eth_send_transaction_with_nonce(
         self, w3: "Web3", unlocked_account: ChecksumAddress
     ) -> None:
@@ -3260,6 +3265,7 @@ def gas_price_strategy(_w3: "Web3", _txn: TxParams) -> str:
         assert txn["gasPrice"] == two_gwei_in_wei
         w3.eth.set_gas_price_strategy(None)  # reset strategy
 
+    @flaky(max_runs=3)
     def test_eth_replace_transaction_legacy(
         self, w3: "Web3", unlocked_account_dual_type: ChecksumAddress
     ) -> None:
@@ -3288,7 +3294,7 @@ def test_eth_replace_transaction_legacy(
         assert replace_txn["gas"] == 21000
         assert replace_txn["gasPrice"] == txn_params["gasPrice"]
 
-    @flaky(max_runs=5)
+    @flaky(max_runs=3)
     def test_eth_replace_transaction(
         self, w3: "Web3", unlocked_account_dual_type: ChecksumAddress
     ) -> None:
@@ -3416,6 +3422,7 @@ def test_eth_replace_transaction_gas_price_too_low(
         with pytest.raises(ValueError):
             w3.eth.replace_transaction(txn_hash, txn_params)
 
+    @flaky(max_runs=3)
     def test_eth_replace_transaction_gas_price_defaulting_minimum(
         self, w3: "Web3", unlocked_account: ChecksumAddress
     ) -> None:
@@ -3438,6 +3445,7 @@ def test_eth_replace_transaction_gas_price_defaulting_minimum(
             gas_price * 1.125
         )  # minimum gas price
 
+    @flaky(max_runs=3)
     def test_eth_replace_transaction_gas_price_defaulting_strategy_higher(
         self, w3: "Web3", unlocked_account: ChecksumAddress
     ) -> None:
@@ -3465,6 +3473,7 @@ def higher_gas_price_strategy(w3: "Web3", txn: TxParams) -> Wei:
         )  # Strategy provides higher gas price
         w3.eth.set_gas_price_strategy(None)  # reset strategy
 
+    @flaky(max_runs=3)
     def test_eth_replace_transaction_gas_price_defaulting_strategy_lower(
         self, w3: "Web3", unlocked_account: ChecksumAddress
     ) -> None:
@@ -3491,6 +3500,7 @@ def lower_gas_price_strategy(w3: "Web3", txn: TxParams) -> Wei:
         assert replace_txn["gasPrice"] == math.ceil(gas_price * 1.125)
         w3.eth.set_gas_price_strategy(None)  # reset strategy
 
+    @flaky(max_runs=3)
     def test_eth_modify_transaction_legacy(
         self, w3: "Web3", unlocked_account: ChecksumAddress
     ) -> None:
@@ -3520,6 +3530,7 @@ def test_eth_modify_transaction_legacy(
         assert modified_txn["gas"] == 21000
         assert modified_txn["gasPrice"] == cast(int, txn_params["gasPrice"]) * 2
 
+    @flaky(max_runs=3)
     def test_eth_modify_transaction(
         self, w3: "Web3", unlocked_account: ChecksumAddress
     ) -> None: