Add eth-tester MethodNotFound response format

Author: kclowes

tests/core/manager/test_response_formatters.py

@@ -41,6 +41,9 @@
         "available",
     },
 }
+ETH_TESTER_METHOD_NOT_FOUND_RESP_FORMAT = {
+    "error": "the method eth_getTransactionByHash does not exist/is not available",
+}
 
 
 def raise_contract_logic_error(response):
@@ -121,6 +124,13 @@ def raise_contract_logic_error(response):
             identity,
             MethodUnavailable,
         ),
+        (
+            ETH_TESTER_METHOD_NOT_FOUND_RESP_FORMAT,
+            (),
+            identity,
+            identity,
+            ValueError,
+        ),
     ],
 )
 def test_formatted_response_raises_errors(

web3/manager.py

@@ -189,8 +189,13 @@ def formatted_response(
     ) -> Any:
         if "error" in response:
             apply_error_formatters(error_formatters, response)
-            if response["error"].get("code") == -32601:
-                raise MethodUnavailable(response["error"])
+
+            # guard against eth-tester case - eth-tester returns a string
+            # with no code, so can't parse what the error is.
+            if isinstance(response["error"], dict):
+                resp_code = response["error"].get("code")
+                if resp_code == -32601:
+                    raise MethodUnavailable(response["error"])
             raise ValueError(response["error"])
         # NULL_RESPONSES includes None, so return False here as the default
         # so we don't apply the null_result_formatters if there is no 'result' key