Move eth_getStorageAt to snake_case

Author: kclowes

docs/overview.rst

@@ -145,7 +145,7 @@ API
 - :meth:`web3.eth.getBlockTransactionCount() <web3.eth.Eth.getBlockTransactionCount>`
 - :meth:`web3.eth.getCode() <web3.eth.Eth.getCode>`
 - :meth:`web3.eth.getProof() <web3.eth.Eth.getProof>`
-- :meth:`web3.eth.getStorageAt() <web3.eth.Eth.getStorageAt>`
+- :meth:`web3.eth.get_storage_at() <web3.eth.Eth.get_storage_at>`
 - :meth:`web3.eth.getTransaction() <web3.eth.Eth.getTransaction>`
 - :meth:`web3.eth.getTransactionByBlock() <web3.eth.Eth.getTransactionByBlock>`
 - :meth:`web3.eth.getTransactionCount() <web3.eth.Eth.getTransactionCount>`

docs/web3.eth.rst

@@ -192,7 +192,7 @@ The following methods are available on the ``web3.eth`` namespace.
       :meth:`~web3.eth.get_balance()`
 
 
-.. py:method:: Eth.getStorageAt(account, position, block_identifier=eth.defaultBlock)
+.. py:method:: Eth.get_storage_at(account, position, block_identifier=eth.defaultBlock)
 
     * Delegates to ``eth_getStorageAt`` RPC Method
 
@@ -207,6 +207,12 @@ The following methods are available on the ``web3.eth`` namespace.
         '0x00000000000000000000000000000000000000000000000000120a0b063499d4'
 
 
+.. py:method:: Eth.getStorageAt(account, position, block_identifier=eth.defaultBlock)
+
+    .. warning:: Deprecated: This method is deprecated in favor of
+      :meth:`~web3.eth.get_storage_at()`
+
+
 .. py:method:: Eth.getProof(account, positions, block_identifier=eth.defaultBlock)
 
     * Delegates to ``eth_getProof`` RPC Method

tests/integration/test_ethereum_tester.py

@@ -316,12 +316,16 @@ def test_eth_call_old_contract_state(self, eth_tester, web3, math_contract, unlo
             raise AssertionError("eth-tester was unexpectedly able to give the pending call result")
 
     @pytest.mark.xfail(reason='json-rpc method is not implemented on eth-tester')
-    def test_eth_getStorageAt(self, web3, emitter_contract_address):
-        super().test_eth_getStorageAt(web3, emitter_contract_address)
+    def test_eth_get_storage_at(self, web3, emitter_contract_address):
+        super().test_eth_get_storage_at(web3, emitter_contract_address)
 
     @pytest.mark.xfail(reason='json-rpc method is not implemented on eth-tester')
-    def test_eth_getStorageAt_ens_name(self, web3, emitter_contract_address):
-        super().test_eth_getStorageAt_ens_name(web3, emitter_contract_address)
+    def test_eth_getStorageAt_deprecated(self, web3, emitter_contract_address):
+        super().test_eth_getStorageAt_deprecated(web3, emitter_contract_address)
+
+    @pytest.mark.xfail(reason='json-rpc method is not implemented on eth-tester')
+    def test_eth_get_storage_at_ens_name(self, web3, emitter_contract_address):
+        super().test_eth_get_storage_at_ens_name(web3, emitter_contract_address)
 
     def test_eth_estimateGas_with_block(self,
                                         web3,

web3/_utils/module_testing/eth_module.py

@@ -169,23 +169,30 @@ def test_eth_get_balance_with_ens_name(
                 with pytest.raises(NameNotFound):
                     web3.eth.get_balance(address)
 
-    def test_eth_getStorageAt(
+    def test_eth_get_storage_at(
         self, web3: "Web3", emitter_contract_address: ChecksumAddress
     ) -> None:
-        storage = web3.eth.getStorageAt(emitter_contract_address, 0)
+        storage = web3.eth.get_storage_at(emitter_contract_address, 0)
         assert isinstance(storage, HexBytes)
 
-    def test_eth_getStorageAt_ens_name(
+    def test_eth_getStorageAt_deprecated(
+        self, web3: "Web3", emitter_contract_address: ChecksumAddress
+    ) -> None:
+        with pytest.warns(DeprecationWarning):
+            storage = web3.eth.getStorageAt(emitter_contract_address, 0)
+            assert isinstance(storage, HexBytes)
+
+    def test_eth_get_storage_at_ens_name(
         self, web3: "Web3", emitter_contract_address: ChecksumAddress
     ) -> None:
         with ens_addresses(web3, {'emitter.eth': emitter_contract_address}):
-            storage = web3.eth.getStorageAt('emitter.eth', 0)
+            storage = web3.eth.get_storage_at('emitter.eth', 0)
             assert isinstance(storage, HexBytes)
 
-    def test_eth_getStorageAt_invalid_address(self, web3: "Web3") -> None:
+    def test_eth_get_storage_at_invalid_address(self, web3: "Web3") -> None:
         coinbase = web3.eth.coinbase
         with pytest.raises(InvalidAddress):
-            web3.eth.getStorageAt(ChecksumAddress(HexAddress(HexStr(coinbase.lower()))), 0)
+            web3.eth.get_storage_at(ChecksumAddress(HexAddress(HexStr(coinbase.lower()))), 0)
 
     def test_eth_getTransactionCount(
         self, web3: "Web3", unlocked_account_dual_type: ChecksumAddress

web3/eth.py

@@ -221,9 +221,7 @@ def get_storage_at_munger(
             block_identifier = self.defaultBlock
         return (account, position, block_identifier)
 
-    getStorageAt: Method[
-        Callable[..., HexBytes]
-    ] = Method(
+    get_storage_at: Method[Callable[..., HexBytes]] = Method(
         RPC.eth_getStorageAt,
         mungers=[get_storage_at_munger],
     )
@@ -567,3 +565,4 @@ def setGasPriceStrategy(self, gas_price_strategy: GasPriceStrategy) -> None:
 
     # Deprecated Methods
     getBalance = DeprecatedMethod(get_balance, 'getBalance', 'get_balance')
+    getStorageAt = DeprecatedMethod(get_storage_at, 'getStorageAt', 'get_storage_at')