Added two more test

Author: dbfreem

tests/ens/test_offchain_resolution.py

@@ -94,6 +94,23 @@ def status(self):
         return self.status_code
 
 
+class AsyncMockHttpBadFormatResponse:
+    status_code = 200
+
+    def __init__(self, *args):
+        assert args[1] == EXPECTED_GET_URL
+
+    @staticmethod
+    def raise_for_status(): pass  # noqa: E704
+
+    @staticmethod
+    async def json(): return {'not_data': OFFCHAIN_RESOLVER_DATA}  # noqa: E704'
+
+    @property
+    def status(self):
+        return self.status_code
+
+
 def test_offchain_resolution_with_get_request(ens, monkeypatch):
     # mock GET response with real return data from 'offchainexample.eth' resolver
     def mock_get(*args, **kwargs):
@@ -169,3 +186,23 @@ async def mock_post(*args, **kwargs):
     monkeypatch.setattr(ClientSession, 'post', mock_post)
 
     assert await async_ens.address('offchainexample.eth') == EXPECTED_RESOLVED_ADDRESS
+
+
+@pytest.mark.asyncio
+async def test_async_offchain_resolution_raises_when_all_supplied_urls_fail(async_ens):
+    # with no mocked responses, requests to all urls will fail
+    with pytest.raises(Exception, match='Offchain lookup failed for supplied urls.'):
+        await async_ens.address('offchainexample.eth')
+
+
+@pytest.mark.asyncio
+async def test_async_offchain_resolution_with_improperly_formatted_http_response(async_ens,
+                                                                                 monkeypatch):
+    async def mock_get(*args, **_):
+        return AsyncMockHttpBadFormatResponse(*args)
+
+    monkeypatch.setattr(ClientSession, 'get', mock_get)
+    with pytest.raises(ValidationError, match=(
+        "Improperly formatted response for offchain lookup HTTP request - missing 'data' field."
+    )):
+        await async_ens.address('offchainexample.eth')