rpc, eth/filters: use non-blocking timer drain pattern #31141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JukLee0ira
requested review from
fjl,
holiman and
rjl493456442
as code owners
|
I don't think its necessary to address this at all. We used the pattern which is documented in package time. If this causes a hang, it's a bug in the Go runtime, and they fixed it in 1.23. We generally only support the latest two releases of Go, which are 1.22 and 1.23 right now. But 1.24 is coming up soon, and we will bump our baseline requirement to 1.23 when it is released. |
qdm12
reviewed
Feb 7, 2025
Comment on lines
+438
to
+441
| select { | ||
| case <-f.deadline.C: | ||
| default: | ||
| } |
There was a problem hiding this comment.
this could indeed deadlock in case there is wrong programming somewhere else. It might be more interesting to check other listeners of f.deadline and make sure they stop listening before the call f.deadline.Stop()? Same for the pingTimer changed in rpc/weboscket.go 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a direct channel receive after
Stop()may block in edge cases. A safer approach is to useselectwith a default case for timer cleanup.PS: I noticed other instances in the code where
Resetis used without draining the timer channel viaStop(). While this is fixed in Go 1.23+, it could cause undefined behavior in earlier versions. Would the team be open to addressing this for compatibility with pre-1.23 Go versions?I’d be happy to fix this in this PR if needed.Ref: golang/go#37196