-
Notifications
You must be signed in to change notification settings - Fork 689
esp_camera_available_frames implementation #723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This would be a great addition, IMHO. Is this under the Radar?? The code looks for me very straight forward. |
Did you tested it with fb_count 1 and 2, as well as grab mode latest and when_empty? |
@cnadler86 not really, but as far as I see this operation is complementary to the operation performed in Line 481 in 4467667
So, we are checking with this new Do you see any additional consideration when fb_count is greater than one, grab mode is the latest or |
I don't think there will be a impact on any current functionality. I can only imagine that the function might return always true or always false in one of the possible configuration cases. I have not taken a deep look at the code and in come cases testing is better than analyzing. That's why I am asking. |
I tested the PR at application level and it behaves as expected. The FPS will be a little less, since you need to assess at application level weather to "take a picture" or perform some other activities, but with this non-blocking code is possible. Great PR! @me-no-dev : could you please take a look and in case it is OK, merge this? |
Available frames pr from espressif#723
This pull request appears to be stale. Please close it if its no longer valid. |
What appears to be stale is the hole repository 🧐 |
Description
This PR adds a functionality for checking if there is an available frame to be read immediately, allowing the possibility of calling
esp_camera_fb_get
ensuring that there would be no block.Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following: