Skip to content

only use ksz8081 for idf versions later than 4.3 (this fixes compile as component for idf 4.3) #5599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 1, 2021
Merged

only use ksz8081 for idf versions later than 4.3 (this fixes compile as component for idf 4.3) #5599

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d221c5c
only use ksz8081 for idf versions later than 4.3
liebman Aug 26, 2021
44c4f69
updates from PR comments
liebman Aug 26, 2021
151af03
add break so as not to fall thur
liebman Aug 26, 2021
34d3e10
Merge branch 'master' into fix-component-with-idf-4.3
me-no-dev Aug 31, 2021
d34a34e
Merge branch 'master' into fix-component-with-idf-4.3
liebman Sep 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions libraries/WiFi/src/ETH.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,8 +287,10 @@ bool ETHClass::begin(uint8_t phy_addr, int power, int mdc, int mdio, eth_phy_typ
eth_phy = esp_eth_phy_new_dm9051(&phy_config);
break;
#endif
#if ESP_IDF_VERSION_MINOR > 3 || ESP_IDF_VERSION_MAJOR > 4 // added starting after 4.3
case ETH_PHY_KSZ8081:
eth_phy = esp_eth_phy_new_ksz8081(&phy_config);
#endif
default:
break;
}
Expand Down