Allow update to function over HTTPS due to peek() missing from mbedTLS. #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed redundant check of magic byte from writeStream() * The magic byte is checked in _writeBuffer() before any flash is altered. * The check using peek earlier will at best only save a wasted read of one buffer length of data being read if data is correupted. * As we are already prepared to read an entire buffers worth of data anyway this saving doesn't matter.
|
hmm.. I thought we added peek to SSL... @copercini am I wrong? |
|
It's on my fork, https://github.com/copercini/arduino-esp32/blob/master/libraries/WiFiClientSecure/src/WiFiClientSecure.cpp#L116 but I don't have a server to test, so it's only theoretically implemented |
|
Can close this now :) |
|
The use of peek() in Updater was still redundant and can/should/could still be removed from Updater.cpp although it is no longer a requirement in order to simply compile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed redundant check of magic byte from writeStream()