Skip to content

bugfix(i2c): fix signal glitch on sda and scl pin #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ESP32DE
Copy link

@ESP32DE ESP32DE commented Feb 3, 2018

see #1061
here a tested version and an optional suggestion

see espressif#1061
here a tested version and an optional suggestion
@ESP32DE
Copy link
Author

ESP32DE commented Feb 3, 2018

note:
i tested the patch with an earlier version successful
if you use the actually version you must use the option
to make the pin HIGH before you setup the pin as OPENDRAIN
( see the comment in the code )

so perhabs would be better, if we use the optional version then,
cause i think, there is nobody using an earlier version ?

just in time tested with the actually version too now
i did use the optional and set Pin Level HIGH before i set it as OPENDRAIN
successful too.

@ESP32DE
Copy link
Author

ESP32DE commented Feb 4, 2018

i will close this PR cause this is only work in a prev version
we must use the optional in the actually version to kick the glitch on sda and scl on wire.begin().
so you will get asap the optional for better merging :)

@ESP32DE ESP32DE closed this Feb 4, 2018
@ESP32DE
Copy link
Author

ESP32DE commented Feb 4, 2018

see PR #1065
i added the optional to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant