Fix memory leak and undefined behavour in Updater.cpp (UpdaterClass) (#8671)

* Fix memory leak and undefined behavour in Updater #7984

* Update error message

Co-authored-by: Jan Procházka <[email protected]>

* Update error message

Co-authored-by: Jan Procházka <[email protected]>

---------

Co-authored-by: Jan Procházka <[email protected]>
Co-authored-by: Me No Dev <[email protected]>

Author: 3 people

libraries/Update/src/Updater.cpp

@@ -76,9 +76,15 @@ UpdateClass& UpdateClass::onProgress(THandlerFunction_Progress fn) {
 }
 
 void UpdateClass::_reset() {
-    if (_buffer)
+    if (_buffer) {
         delete[] _buffer;
-    _buffer = 0;
+    }
+    if (_skipBuffer) {
+        delete[] _skipBuffer;
+    }
+
+    _buffer = nullptr;
+    _skipBuffer = nullptr;
     _bufferLen = 0;
     _progress = 0;
     _size = 0;
@@ -159,9 +165,9 @@ bool UpdateClass::begin(size_t size, int command, int ledPin, uint8_t ledOn, con
     }
 
     //initialize
-    _buffer = (uint8_t*)malloc(SPI_FLASH_SEC_SIZE);
-    if(!_buffer){
-        log_e("malloc failed");
+    _buffer = new (std::nothrow) uint8_t[SPI_FLASH_SEC_SIZE];
+    if (!_buffer) {
+        log_e("_buffer allocation failed");
         return false;
     }
     _size = size;
@@ -193,10 +199,10 @@ bool UpdateClass::_writeBuffer(){
         //not written at this point so that partially written firmware
         //will not be bootable
         skip = ENCRYPTED_BLOCK_SIZE;
-        _skipBuffer = (uint8_t*)malloc(skip);
-        if(!_skipBuffer){
-            log_e("malloc failed");
-        return false;
+        _skipBuffer = new (std::nothrow) uint8_t[skip];
+        if (!_skipBuffer) {
+            log_e("_skipBuffer allocation failed");
+            return false;
         }
         memcpy(_skipBuffer, _buffer, skip);
     }