Skip to content

Conversation

hyperz111
Copy link
Contributor

@hyperz111 hyperz111 commented Sep 22, 2025

Prerequisites checklist

What is the purpose of this pull request?

Update prompt UI.

What changes did you make? (Give an overview)

  • Add ansi-colors which is a dependency of enquirer for coloring. It provides symbols too.
  • Add & update log utilities.
  • Change the radio symbol of select & multiselect from ✔️ to ⚫.
  • And other...

Related Issues

refs #197

Is there anything you'd like reviewers to focus on?

N/A

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the interactive prompt UI and logging utilities to use ansi-colors for consistent symbols and colorized output, and standardizes question styling for enquirer prompts.

  • Add ansi-colors dependency and introduce colorized, symbol-prefixed logging helpers.
  • Centralize enquirer prompt styling via setQuestionsPromptStyle and switch select/multiselect indicators to radio symbols.
  • Adjust call sites to use new logging helpers.

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Adds ansi-colors dependency to support colored symbols in prompts/logs.
lib/utils/npm-utils.js Imports only error from logging to use as logError.
lib/utils/logging.js Adds colorized log helpers (log, success, info, warn, error) with symbols.
lib/questions.js Introduces setQuestionsPromptStyle and applies it to all exported question sets, including updated indicator symbols.
lib/config-generator.js Switches some log.info calls to log.log and uses log.success for success messages.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

aladdin-add
aladdin-add previously approved these changes Sep 23, 2025
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Would like another review before merging.

@aladdin-add
Copy link
Member

🙌for reviewers, this is how it looks now:

image image

@aladdin-add aladdin-add moved this from Implementing to Second Review Needed in Triage Sep 23, 2025
@hyperz111
Copy link
Contributor Author

@aladdin-add, can you review it again?

aladdin-add
aladdin-add previously approved these changes Sep 24, 2025
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aladdin-add aladdin-add requested a review from a team September 24, 2025 07:15
@hyperz111
Copy link
Contributor Author

@aladdin-add, can you merge this?

@aladdin-add
Copy link
Member

Waiting @lumirlumir and @JoshuaKGoldberg to review. Let's be a little patient. :)

Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! The added ✔s are a nice touch. There are still some unrelated changes in this PR that should be reverted for a smaller diff, as well as a bug in bold/strong text.

@JoshuaKGoldberg JoshuaKGoldberg moved this from Second Review Needed to Implementing in Triage Sep 25, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated UI looks good to me. I found a few more places that could be cleaned up, so I've left some comments.

Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would like @aladdin-add and @JoshuaKGoldberg to verify the changes before merging.

@lumirlumir lumirlumir moved this from Implementing to Second Review Needed in Triage Sep 30, 2025
@hyperz111
Copy link
Contributor Author

@JoshuaKGoldberg, can you review it?

Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, nicely done! 🚀

@JoshuaKGoldberg JoshuaKGoldberg merged commit cf7f3e0 into eslint:main Oct 7, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Oct 7, 2025
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
@hyperz111 hyperz111 deleted the update-ui branch October 7, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

4 participants