-
-
Notifications
You must be signed in to change notification settings - Fork 28
feat: update ui #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update ui #202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the interactive prompt UI and logging utilities to use ansi-colors for consistent symbols and colorized output, and standardizes question styling for enquirer prompts.
- Add ansi-colors dependency and introduce colorized, symbol-prefixed logging helpers.
- Centralize enquirer prompt styling via setQuestionsPromptStyle and switch select/multiselect indicators to radio symbols.
- Adjust call sites to use new logging helpers.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
package.json | Adds ansi-colors dependency to support colored symbols in prompts/logs. |
lib/utils/npm-utils.js | Imports only error from logging to use as logError. |
lib/utils/logging.js | Adds colorized log helpers (log, success, info, warn, error) with symbols. |
lib/questions.js | Introduces setQuestionsPromptStyle and applies it to all exported question sets, including updated indicator symbols. |
lib/config-generator.js | Switches some log.info calls to log.log and uses log.success for success messages. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Would like another review before merging.
@aladdin-add, can you review it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@aladdin-add, can you merge this? |
Waiting @lumirlumir and @JoshuaKGoldberg to review. Let's be a little patient. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! The added ✔s are a nice touch. There are still some unrelated changes in this PR that should be reverted for a smaller diff, as well as a bug in bold/strong text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated UI looks good to me. I found a few more places that could be cleaned up, so I've left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would like @aladdin-add and @JoshuaKGoldberg to verify the changes before merging.
@JoshuaKGoldberg, can you review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, nicely done! 🚀
Prerequisites checklist
What is the purpose of this pull request?
Update prompt UI.
What changes did you make? (Give an overview)
ansi-colors
which is a dependency ofenquirer
for coloring. It provides symbols too.select
&multiselect
from ✔️ to ⚫.Related Issues
refs #197
Is there anything you'd like reviewers to focus on?
N/A