-
-
Notifications
You must be signed in to change notification settings - Fork 28
fix: exit gracefully on Ctrl+C
#194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is like #189 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is no test for this file, I've tested manually, and it's working as expected.
LGTM. Would like another review before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, thank you.
Prerequisites checklist
What is the purpose of this pull request?
Prevent a crash when pressing
Ctrl+C
by exiting gracefully.What changes did you make? (Give an overview)
Added an
uncaughtException
handler that catchesERR_USE_AFTER_CLOSE
and callsprocess.exit(1)
, rethrowing other errors.Related Issues
Fixes #192
Is there anything you'd like reviewers to focus on?