Skip to content

Conversation

Pixel998
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

Prevent a crash when pressing Ctrl+C by exiting gracefully.

What changes did you make? (Give an overview)

Added an uncaughtException handler that catches ERR_USE_AFTER_CLOSE and calls process.exit(1), rethrowing other errors.

Related Issues

Fixes #192

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Sep 11, 2025
@eslintbot eslintbot added this to Triage Sep 11, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Sep 11, 2025
@hyperz111
Copy link
Contributor

This is like #189

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is no test for this file, I've tested manually, and it's working as expected.

LGTM. Would like another review before merging.

@aladdin-add aladdin-add moved this from Needs Triage to Second Review Needed in Triage Sep 17, 2025
@aladdin-add aladdin-add requested a review from a team September 17, 2025 03:49
Copy link

@DMartens DMartens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thank you.

@aladdin-add aladdin-add merged commit 2127040 into eslint:main Sep 22, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted bug Something isn't working

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Aborting with Ctrl+C causes crash

5 participants