included check for string literal 'error'

Jordan Thomson · Jordan Thomson · commit ee0a8d41f786 · 2020-08-06T16:19:14.000+10:00
diff --git a/__tests__/prefer-await-to-callbacks.js b/__tests__/prefer-await-to-callbacks.js
@@ -51,6 +51,14 @@ ruleTester.run('prefer-await-to-callbacks', rule, {
     {
       code: 'callback()',
       errors: [{ message }]
+    },
+    {
+      code: 'heart(error => {})',
+      errors: [{ message }]
+    },
+    {
+      code: 'heart(function(error) {})',
+      errors: [{ message }]
     }
   ]
 })
diff --git a/rules/prefer-await-to-callbacks.js b/rules/prefer-await-to-callbacks.js
@@ -50,7 +50,11 @@ module.exports = {
           ) {
             return
           }
-          if (arg.params && arg.params[0] && arg.params[0].name === 'err') {
+          if (
+            arg.params &&
+            arg.params[0] &&
+            (arg.params[0].name === 'err' || arg.params[0].name === 'error')
+          ) {
             if (!isInsideYieldOrAwait()) {
               context.report({ node: arg, messageId: 'error' })
             }

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,14 @@ ruleTester.run('prefer-await-to-callbacks', rule, {`
`51`	`51`	`{`
`52`	`52`	`code: 'callback()',`
`53`	`53`	`errors: [{ message }]`
	`54`	`+ },`
	`55`	`+ {`
	`56`	`+ code: 'heart(error => {})',`
	`57`	`+ errors: [{ message }]`
	`58`	`+ },`
	`59`	`+ {`
	`60`	`+ code: 'heart(function(error) {})',`
	`61`	`+ errors: [{ message }]`
`54`	`62`	`}`
`55`	`63`	`]`
`56`	`64`	`})`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,11 @@ module.exports = {`
`50`	`50`	`) {`
`51`	`51`	`return`
`52`	`52`	`}`
`53`		`- if (arg.params && arg.params[0] && arg.params[0].name === 'err') {`
	`53`	`+ if (`
	`54`	`+ arg.params &&`
	`55`	`+ arg.params[0] &&`
	`56`	`+ (arg.params[0].name === 'err' \|\| arg.params[0].name === 'error')`
	`57`	`+ ) {`
`54`	`58`	`if (!isInsideYieldOrAwait()) {`
`55`	`59`	`context.report({ node: arg, messageId: 'error' })`
`56`	`60`	`}`