Skip to content

Commit d1e03a1

Browse files
authored
fix: ensure rules bail out early when no rule present (#293)
1 parent d06d1f2 commit d1e03a1

37 files changed

+147
-45
lines changed

lib/rules/meta-property-ordering.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,9 @@ module.exports = {
3636
create(context) {
3737
const sourceCode = context.getSourceCode();
3838
const info = getRuleInfo(sourceCode);
39+
if (!info) {
40+
return {};
41+
}
3942

4043
const order = context.options[0] || [
4144
'type',
@@ -50,7 +53,7 @@ module.exports = {
5053

5154
return {
5255
Program() {
53-
if (!info || !info.meta || info.meta.properties.length < 2) {
56+
if (!info.meta || info.meta.properties.length < 2) {
5457
return;
5558
}
5659

lib/rules/no-missing-message-ids.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ module.exports = {
2929
const sourceCode = context.getSourceCode();
3030
const { scopeManager } = sourceCode;
3131
const ruleInfo = utils.getRuleInfo(sourceCode);
32+
if (!ruleInfo) {
33+
return {};
34+
}
3235

3336
const messagesNode = utils.getMessagesNode(ruleInfo, scopeManager);
3437

lib/rules/no-missing-placeholders.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,10 @@ module.exports = {
3737
let contextIdentifiers;
3838

3939
const ruleInfo = utils.getRuleInfo(sourceCode);
40+
if (!ruleInfo) {
41+
return {};
42+
}
43+
4044
const messagesNode = utils.getMessagesNode(ruleInfo, scopeManager);
4145

4246
return {

lib/rules/no-unused-message-ids.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ module.exports = {
2727
const sourceCode = context.getSourceCode();
2828
const { scopeManager } = sourceCode;
2929
const info = utils.getRuleInfo(sourceCode);
30+
if (!info) {
31+
return {};
32+
}
3033

3134
const messageIdsUsed = new Set();
3235
let contextIdentifiers;

lib/rules/no-unused-placeholders.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,9 @@ module.exports = {
3737
let contextIdentifiers;
3838

3939
const ruleInfo = utils.getRuleInfo(sourceCode);
40+
if (!ruleInfo) {
41+
return {};
42+
}
4043
const messagesNode = utils.getMessagesNode(ruleInfo, scopeManager);
4144

4245
return {

lib/rules/prefer-message-ids.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ module.exports = {
3030
create(context) {
3131
const sourceCode = context.getSourceCode();
3232
const info = utils.getRuleInfo(sourceCode);
33+
if (!info) {
34+
return {};
35+
}
3336

3437
let contextIdentifiers;
3538

@@ -44,10 +47,6 @@ module.exports = {
4447
ast
4548
);
4649

47-
if (info === null) {
48-
return;
49-
}
50-
5150
const metaNode = info.meta;
5251
const messagesNode =
5352
metaNode &&

lib/rules/prefer-object-rule.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,13 @@ module.exports = {
3434

3535
const sourceCode = context.getSourceCode();
3636
const ruleInfo = utils.getRuleInfo(sourceCode);
37+
if (!ruleInfo) {
38+
return {};
39+
}
3740

3841
return {
3942
Program() {
40-
if (!ruleInfo || ruleInfo.isNewStyle) {
43+
if (ruleInfo.isNewStyle) {
4144
return;
4245
}
4346

lib/rules/report-message-format.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,18 +57,23 @@ module.exports = {
5757
}
5858
}
5959

60+
const sourceCode = context.getSourceCode();
61+
const ruleInfo = utils.getRuleInfo(sourceCode);
62+
if (!ruleInfo) {
63+
return {};
64+
}
65+
6066
// ----------------------------------------------------------------------
6167
// Public
6268
// ----------------------------------------------------------------------
6369

6470
return {
6571
Program(ast) {
66-
const sourceCode = context.getSourceCode();
6772
contextIdentifiers = utils.getContextIdentifiers(
6873
sourceCode.scopeManager,
6974
ast
7075
);
71-
const ruleInfo = utils.getRuleInfo(sourceCode);
76+
7277
const messagesObject =
7378
ruleInfo &&
7479
ruleInfo.meta &&

lib/rules/require-meta-docs-description.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,15 @@ module.exports = {
4242
},
4343

4444
create(context) {
45+
const sourceCode = context.getSourceCode();
46+
const info = utils.getRuleInfo(sourceCode);
47+
if (!info) {
48+
return {};
49+
}
50+
4551
return {
4652
Program() {
47-
const sourceCode = context.getSourceCode();
4853
const { scopeManager } = sourceCode;
49-
const info = utils.getRuleInfo(sourceCode);
50-
51-
if (info === null) {
52-
return;
53-
}
5454

5555
const pattern =
5656
context.options[0] && context.options[0].pattern

lib/rules/require-meta-docs-url.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -72,16 +72,16 @@ module.exports = {
7272
);
7373
}
7474

75+
const sourceCode = context.getSourceCode();
76+
const info = util.getRuleInfo(sourceCode);
77+
if (!info) {
78+
return {};
79+
}
80+
7581
return {
7682
Program() {
77-
const sourceCode = context.getSourceCode();
7883
const { scopeManager } = sourceCode;
7984

80-
const info = util.getRuleInfo(sourceCode);
81-
if (info === null) {
82-
return;
83-
}
84-
8585
const metaNode = info.meta;
8686
const docsPropNode = util
8787
.evaluateObjectProperties(metaNode, scopeManager)

0 commit comments

Comments
 (0)