upstream: Sirupsen -> sirupsen name change #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2018 the GitHub "organization" github.com/Sirupsen changed to all lower case. While this was fine in a pre "Go Modules" world, this cases breaking changes when using modules within Go. A number of other Go projects have experienced this, for more detail reference the following: golang/go#28489 golang/go#26208
|
Looking into failed tests. Will force push an update to re-test this evening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2018 the GitHub "organization" github.com/Sirupsen changed to all
lower case. While this was fine in a pre "Go Modules" world, this cases
breaking changes when using modules within Go.
A number of other Go projects have experienced this, for more detail
reference the following:
golang/go#28489
golang/go#26208