Skip to content

Commit 4ae9339

Browse files
committed
Rename from iterator to iterable
and split the functionality facebook#19831
1 parent 26857ec commit 4ae9339

File tree

1 file changed

+8
-4
lines changed
  • packages/react-devtools-shared/src

1 file changed

+8
-4
lines changed

packages/react-devtools-shared/src/utils.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,8 @@ export type DataType =
400400
| 'html_all_collection'
401401
| 'html_element'
402402
| 'infinity'
403-
| 'iterator'
403+
| 'iterable'
404+
| 'opaque_iterable'
404405
| 'nan'
405406
| 'null'
406407
| 'number'
@@ -460,8 +461,11 @@ export function getDataType(data: Object): DataType {
460461
// If it doesn't error, we know it's an ArrayBuffer,
461462
// but this seems kind of awkward and expensive.
462463
return 'array_buffer';
463-
} else if (typeof data[Symbol.iterator] === 'function') {
464-
return 'iterator';
464+
}else if (data()[Symbol.iterator]() === 'data') {
465+
return 'opaque_iterable';
466+
}
467+
else if (typeof data[Symbol.iterator] === 'function') {
468+
return 'iterable';
465469
} else if (data.constructor && data.constructor.name === 'RegExp') {
466470
return 'regexp';
467471
} else {
@@ -638,7 +642,7 @@ export function formatDataForPreview(
638642
} else {
639643
return shortName;
640644
}
641-
case 'iterator':
645+
case 'iterable':
642646
const name = data.constructor.name;
643647
if (showFormattedValue) {
644648
// TRICKY

0 commit comments

Comments
 (0)