Clean up leak tracker instrumentation tech debt. (#164070)

Fixes flutter/flutter#137435

Tests are not needed because it is refactoring. Requested
[exempt](https://discord.com/channels/608014603317936148/608018585025118217/1343801945982505001).

@goderbauer , if looks good, can you merge it please, to avoid
conflicts, as there are many files here?

Author: polina-c

packages/flutter/lib/src/animation/animation_controller.dart

@@ -23,8 +23,6 @@ export 'package:flutter/scheduler.dart' show TickerFuture, TickerProvider;
 export 'animation.dart' show Animation, AnimationStatus;
 export 'curves.dart' show Curve;
 
-const String _flutterAnimationLibrary = 'package:flutter/animation.dart';
-
 // Examples can assume:
 // late AnimationController _controller, fadeAnimationController, sizeAnimationController;
 // late bool dismissed;
@@ -255,9 +253,7 @@ class AnimationController extends Animation<double>
     required TickerProvider vsync,
   }) : assert(upperBound >= lowerBound),
        _direction = _AnimationDirection.forward {
-    if (kFlutterMemoryAllocationsEnabled) {
-      _maybeDispatchObjectCreation();
-    }
+    assert(debugMaybeDispatchCreated('animation', 'AnimationController', this));
     _ticker = vsync.createTicker(_tick);
     _internalSetValue(value ?? lowerBound);
   }
@@ -289,24 +285,11 @@ class AnimationController extends Animation<double>
   }) : lowerBound = double.negativeInfinity,
        upperBound = double.infinity,
        _direction = _AnimationDirection.forward {
-    if (kFlutterMemoryAllocationsEnabled) {
-      _maybeDispatchObjectCreation();
-    }
+    assert(debugMaybeDispatchCreated('animation', 'AnimationController', this));
     _ticker = vsync.createTicker(_tick);
     _internalSetValue(value);
   }
 
-  /// Dispatches event of object creation to [FlutterMemoryAllocations.instance].
-  void _maybeDispatchObjectCreation() {
-    if (kFlutterMemoryAllocationsEnabled) {
-      FlutterMemoryAllocations.instance.dispatchObjectCreated(
-        library: _flutterAnimationLibrary,
-        className: '$AnimationController',
-        object: this,
-      );
-    }
-  }
-
   /// The value at which this animation is deemed to be dismissed.
   final double lowerBound;
 
@@ -946,9 +929,7 @@ class AnimationController extends Animation<double>
       }
       return true;
     }());
-    if (kFlutterMemoryAllocationsEnabled) {
-      FlutterMemoryAllocations.instance.dispatchObjectDisposed(object: this);
-    }
+    assert(debugMaybeDispatchDisposed(this));
     _ticker!.dispose();
     _ticker = null;
     clearStatusListeners();

packages/flutter/lib/src/animation/animations.dart

@@ -505,15 +505,7 @@ class TrainHoppingAnimation extends Animation<double>
     this._nextTrain, {
     this.onSwitchedTrain,
   }) {
-    // TODO(polina-c): stop duplicating code across disposables
-    // https://github.com/flutter/flutter/issues/137435
-    if (kFlutterMemoryAllocationsEnabled) {
-      FlutterMemoryAllocations.instance.dispatchObjectCreated(
-        library: 'package:flutter/animation.dart',
-        className: '$TrainHoppingAnimation',
-        object: this,
-      );
-    }
+    assert(debugMaybeDispatchCreated('animation', 'TrainHoppingAnimation', this));
     if (_nextTrain != null) {
       if (_currentTrain!.value == _nextTrain!.value) {
         _currentTrain = _nextTrain;
@@ -598,11 +590,7 @@ class TrainHoppingAnimation extends Animation<double>
   /// After this is called, this object is no longer usable.
   @override
   void dispose() {
-    // TODO(polina-c): stop duplicating code across disposables
-    // https://github.com/flutter/flutter/issues/137435
-    if (kFlutterMemoryAllocationsEnabled) {
-      FlutterMemoryAllocations.instance.dispatchObjectDisposed(object: this);
-    }
+    assert(debugMaybeDispatchDisposed(this));
     assert(_currentTrain != null);
     _currentTrain!.removeStatusListener(_statusChangeHandler);
     _currentTrain!.removeListener(_valueChangeHandler);

packages/flutter/lib/src/foundation/change_notifier.dart

@@ -11,6 +11,7 @@ import 'dart:ui' show VoidCallback;
 import 'package:meta/meta.dart';
 
 import 'assertions.dart';
+import 'debug.dart';
 import 'diagnostics.dart';
 import 'memory_allocations.dart';
 
@@ -100,8 +101,6 @@ abstract class ValueListenable<T> extends Listenable {
   T get value;
 }
 
-const String _flutterFoundationLibrary = 'package:flutter/foundation.dart';
-
 /// A class that can be extended or mixed in that provides a change notification
 /// API using [VoidCallback] for notifications.
 ///
@@ -156,7 +155,7 @@ mixin class ChangeNotifier implements Listenable {
   ///
   /// As [ChangeNotifier] is used as mixin, it does not have constructor,
   /// so we use [addListener] to dispatch the event.
-  bool _creationDispatched = false;
+  bool _debugCreationDispatched = false;
 
   /// Used by subclasses to assert that the [ChangeNotifier] has not yet been
   /// disposed.
@@ -232,16 +231,13 @@ mixin class ChangeNotifier implements Listenable {
   /// so that the method is tree-shaken away when the flag is false.
   @protected
   static void maybeDispatchObjectCreation(ChangeNotifier object) {
-    // Tree shaker does not include this method and the class MemoryAllocations
-    // if kFlutterMemoryAllocationsEnabled is false.
-    if (kFlutterMemoryAllocationsEnabled && !object._creationDispatched) {
-      FlutterMemoryAllocations.instance.dispatchObjectCreated(
-        library: _flutterFoundationLibrary,
-        className: '$ChangeNotifier',
-        object: object,
-      );
-      object._creationDispatched = true;
-    }
+    assert(() {
+      if (!object._debugCreationDispatched) {
+        debugMaybeDispatchCreated('foundation', 'ChangeNotifier', object);
+        object._debugCreationDispatched = true;
+      }
+      return true;
+    }());
   }
 
   /// Register a closure to be called when the object changes.
@@ -387,11 +383,11 @@ mixin class ChangeNotifier implements Listenable {
     );
     assert(() {
       _debugDisposed = true;
+      if (_debugCreationDispatched) {
+        assert(debugMaybeDispatchDisposed(this));
+      }
       return true;
     }());
-    if (kFlutterMemoryAllocationsEnabled && _creationDispatched) {
-      FlutterMemoryAllocations.instance.dispatchObjectDisposed(object: this);
-    }
     _listeners = _emptyListeners;
     _count = 0;
   }

packages/flutter/lib/src/gestures/multidrag.dart

@@ -39,15 +39,7 @@ abstract class MultiDragPointerState {
   /// Creates per-pointer state for a [MultiDragGestureRecognizer].
   MultiDragPointerState(this.initialPosition, this.kind, this.gestureSettings)
     : _velocityTracker = VelocityTracker.withKind(kind) {
-    // TODO(polina-c): stop duplicating code across disposables
-    // https://github.com/flutter/flutter/issues/137435
-    if (kFlutterMemoryAllocationsEnabled) {
-      FlutterMemoryAllocations.instance.dispatchObjectCreated(
-        library: 'package:flutter/gestures.dart',
-        className: '$MultiDragPointerState',
-        object: this,
-      );
-    }
+    assert(debugMaybeDispatchCreated('gestures', 'MultiDragPointerState', this));
   }
 
   /// Device specific gesture configuration that should be preferred over
@@ -195,11 +187,7 @@ abstract class MultiDragPointerState {
   @protected
   @mustCallSuper
   void dispose() {
-    // TODO(polina-c): stop duplicating code across disposables
-    // https://github.com/flutter/flutter/issues/137435
-    if (kFlutterMemoryAllocationsEnabled) {
-      FlutterMemoryAllocations.instance.dispatchObjectDisposed(object: this);
-    }
+    assert(debugMaybeDispatchDisposed(this));
     _arenaEntry?.resolve(GestureDisposition.rejected);
     _arenaEntry = null;
     assert(() {

packages/flutter/lib/src/gestures/recognizer.dart

@@ -142,15 +142,7 @@ abstract class GestureRecognizer extends GestureArenaMember with DiagnosticableT
     this.supportedDevices,
     this.allowedButtonsFilter = _defaultButtonAcceptBehavior,
   }) {
-    // TODO(polina-c): stop duplicating code across disposables
-    // https://github.com/flutter/flutter/issues/137435
-    if (kFlutterMemoryAllocationsEnabled) {
-      FlutterMemoryAllocations.instance.dispatchObjectCreated(
-        library: 'package:flutter/gestures.dart',
-        className: '$GestureRecognizer',
-        object: this,
-      );
-    }
+    assert(debugMaybeDispatchCreated('gestures', 'GestureRecognizer', this));
   }
 
   /// The recognizer's owner.
@@ -313,11 +305,7 @@ abstract class GestureRecognizer extends GestureArenaMember with DiagnosticableT
   /// GestureDetector widget calls this method).
   @mustCallSuper
   void dispose() {
-    // TODO(polina-c): stop duplicating code across disposables
-    // https://github.com/flutter/flutter/issues/137435
-    if (kFlutterMemoryAllocationsEnabled) {
-      FlutterMemoryAllocations.instance.dispatchObjectDisposed(object: this);
-    }
+    assert(debugMaybeDispatchDisposed(this));
   }
 
   /// Returns a very short pretty description of the gesture that the

packages/flutter/lib/src/material/material.dart

@@ -677,15 +677,7 @@ abstract class InkFeature {
     required this.referenceBox,
     this.onRemoved,
   }) : _controller = controller as _RenderInkFeatures {
-    // TODO(polina-c): stop duplicating code across disposables
-    // https://github.com/flutter/flutter/issues/137435
-    if (kFlutterMemoryAllocationsEnabled) {
-      FlutterMemoryAllocations.instance.dispatchObjectCreated(
-        library: 'package:flutter/material.dart',
-        className: '$InkFeature',
-        object: this,
-      );
-    }
+    assert(debugMaybeDispatchCreated('material', 'InkFeature', this));
   }
 
   /// The [MaterialInkController] associated with this [InkFeature].
@@ -711,11 +703,7 @@ abstract class InkFeature {
       _debugDisposed = true;
       return true;
     }());
-    // TODO(polina-c): stop duplicating code across disposables
-    // https://github.com/flutter/flutter/issues/137435
-    if (kFlutterMemoryAllocationsEnabled) {
-      FlutterMemoryAllocations.instance.dispatchObjectDisposed(object: this);
-    }
+    assert(debugMaybeDispatchDisposed(this));
     _controller._removeFeature(this);
     onRemoved?.call();
   }

packages/flutter/lib/src/material/mergeable_material.dart

@@ -146,15 +146,7 @@ class _AnimationTuple {
     required this.endAnimation,
     required this.gapAnimation,
   }) {
-    // TODO(polina-c): stop duplicating code across disposables
-    // https://github.com/flutter/flutter/issues/137435
-    if (kFlutterMemoryAllocationsEnabled) {
-      FlutterMemoryAllocations.instance.dispatchObjectCreated(
-        library: 'package:flutter/material.dart',
-        className: '$_AnimationTuple',
-        object: this,
-      );
-    }
+    assert(debugMaybeDispatchCreated('material', '_AnimationTuple', this));
   }
 
   final AnimationController controller;
@@ -165,9 +157,7 @@ class _AnimationTuple {
 
   @mustCallSuper
   void dispose() {
-    if (kFlutterMemoryAllocationsEnabled) {
-      FlutterMemoryAllocations.instance.dispatchObjectDisposed(object: this);
-    }
+    assert(debugMaybeDispatchDisposed(this));
     controller.dispose();
     startAnimation.dispose();
     endAnimation.dispose();

packages/flutter/lib/src/material/tabs.dart

@@ -480,15 +480,7 @@ class _IndicatorPainter extends CustomPainter {
     required this.indicatorAnimation,
     required this.textDirection,
   }) : super(repaint: controller.animation) {
-    // TODO(polina-c): stop duplicating code across disposables
-    // https://github.com/flutter/flutter/issues/137435
-    if (kFlutterMemoryAllocationsEnabled) {
-      FlutterMemoryAllocations.instance.dispatchObjectCreated(
-        library: 'package:flutter/material.dart',
-        className: '$_IndicatorPainter',
-        object: this,
-      );
-    }
+    assert(debugMaybeDispatchCreated('material', '_IndicatorPainter', this));
     if (old != null) {
       saveTabOffsets(old._currentTabOffsets, old._currentTextDirection);
     }
@@ -521,9 +513,7 @@ class _IndicatorPainter extends CustomPainter {
   }
 
   void dispose() {
-    if (kFlutterMemoryAllocationsEnabled) {
-      FlutterMemoryAllocations.instance.dispatchObjectDisposed(object: this);
-    }
+    assert(debugMaybeDispatchDisposed(this));
     _painter?.dispose();
   }
 

packages/flutter/lib/src/material/time_picker.dart

@@ -957,15 +957,7 @@ class _DialPainter extends CustomPainter {
     required this.textDirection,
     required this.selectedValue,
   }) : super(repaint: PaintingBinding.instance.systemFonts) {
-    // TODO(polina-c): stop duplicating code across disposables
-    // https://github.com/flutter/flutter/issues/137435
-    if (kFlutterMemoryAllocationsEnabled) {
-      FlutterMemoryAllocations.instance.dispatchObjectCreated(
-        library: 'package:flutter/material.dart',
-        className: '$_DialPainter',
-        object: this,
-      );
-    }
+    assert(debugMaybeDispatchCreated('material', '_DialPainter', this));
   }
 
   final List<_TappableLabel> primaryLabels;
@@ -982,9 +974,7 @@ class _DialPainter extends CustomPainter {
   final int selectedValue;
 
   void dispose() {
-    if (kFlutterMemoryAllocationsEnabled) {
-      FlutterMemoryAllocations.instance.dispatchObjectDisposed(object: this);
-    }
+    assert(debugMaybeDispatchDisposed(this));
     for (final _TappableLabel label in primaryLabels) {
       label.painter.dispose();
     }

packages/flutter/lib/src/painting/decoration_image.dart

@@ -319,15 +319,7 @@ abstract interface class DecorationImagePainter {
 
 class _DecorationImagePainter implements DecorationImagePainter {
   _DecorationImagePainter._(this._details, this._onChanged) {
-    // TODO(polina-c): stop duplicating code across disposables
-    // https://github.com/flutter/flutter/issues/137435
-    if (kFlutterMemoryAllocationsEnabled) {
-      FlutterMemoryAllocations.instance.dispatchObjectCreated(
-        library: 'package:flutter/painting.dart',
-        className: '$_DecorationImagePainter',
-        object: this,
-      );
-    }
+    assert(debugMaybeDispatchCreated('painting', '_DecorationImagePainter', this));
   }
 
   final DecorationImage _details;
@@ -438,9 +430,7 @@ class _DecorationImagePainter implements DecorationImagePainter {
 
   @override
   void dispose() {
-    if (kFlutterMemoryAllocationsEnabled) {
-      FlutterMemoryAllocations.instance.dispatchObjectDisposed(object: this);
-    }
+    assert(debugMaybeDispatchDisposed(this));
     _imageStream?.removeListener(ImageStreamListener(_handleImage, onError: _details.onError));
     _image?.dispose();
     _image = null;
@@ -862,15 +852,7 @@ class _BlendedDecorationImage implements DecorationImage {
 
 class _BlendedDecorationImagePainter implements DecorationImagePainter {
   _BlendedDecorationImagePainter._(this.a, this.b, this.t) {
-    // TODO(polina-c): stop duplicating code across disposables
-    // https://github.com/flutter/flutter/issues/137435
-    if (kFlutterMemoryAllocationsEnabled) {
-      FlutterMemoryAllocations.instance.dispatchObjectCreated(
-        library: 'package:flutter/painting.dart',
-        className: '$_BlendedDecorationImagePainter',
-        object: this,
-      );
-    }
+    assert(debugMaybeDispatchCreated('painting', '_BlendedDecorationImagePainter', this));
   }
 
   final DecorationImagePainter? a;
@@ -901,9 +883,7 @@ class _BlendedDecorationImagePainter implements DecorationImagePainter {
 
   @override
   void dispose() {
-    if (kFlutterMemoryAllocationsEnabled) {
-      FlutterMemoryAllocations.instance.dispatchObjectDisposed(object: this);
-    }
+    assert(debugMaybeDispatchDisposed(this));
     a?.dispose();
     b?.dispose();
   }