Skip to content

Commit ead6b0d

Browse files
authored
Remove left-over traces of "link-dry-run" - which isn't used anywhere in flutter (flutter#155820)
The "link-dry-run" functionality was never used in flutter (even before the recent refactoring). I think we can remove this "link-dry-run" concept everywhere. PR to remove this in dart-lang/native: dart-lang/native#1613
1 parent 9be22b5 commit ead6b0d

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

packages/flutter_tools/test/general.shard/isolated/fake_native_assets_build_runner.dart

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@ import 'package:package_config/package_config_types.dart';
1515

1616
/// Mocks all logic instead of using `package:native_assets_builder`, which
1717
/// relies on doing process calls to `pub` and the local file system.
18-
class FakeFlutterNativeAssetsBuildRunner implements FlutterNativeAssetsBuildRunner {
18+
class FakeFlutterNativeAssetsBuildRunner
19+
implements FlutterNativeAssetsBuildRunner {
1920
FakeFlutterNativeAssetsBuildRunner({
2021
this.hasPackageConfigResult = true,
2122
this.packagesWithNativeAssetsResult = const <Package>[],
2223
this.onBuild,
2324
this.buildDryRunResult = const FakeFlutterNativeAssetsBuilderResult(),
2425
this.buildResult = const FakeFlutterNativeAssetsBuilderResult(),
2526
this.linkResult = const FakeFlutterNativeAssetsBuilderResult(),
26-
this.linkDryRunResult = const FakeFlutterNativeAssetsBuilderResult(),
2727
CCompilerConfigImpl? cCompilerConfigResult,
2828
CCompilerConfigImpl? ndkCCompilerConfigImplResult,
2929
}) : cCompilerConfigResult = cCompilerConfigResult ?? CCompilerConfigImpl(),
@@ -34,7 +34,6 @@ class FakeFlutterNativeAssetsBuildRunner implements FlutterNativeAssetsBuildRunn
3434
final native_assets_builder.BuildResult buildResult;
3535
final native_assets_builder.LinkResult linkResult;
3636
final native_assets_builder.BuildDryRunResult buildDryRunResult;
37-
final native_assets_builder.LinkDryRunResult linkDryRunResult;
3837
final bool hasPackageConfigResult;
3938
final List<Package> packagesWithNativeAssetsResult;
4039
final CCompilerConfigImpl cCompilerConfigResult;
@@ -43,7 +42,6 @@ class FakeFlutterNativeAssetsBuildRunner implements FlutterNativeAssetsBuildRunn
4342
int buildInvocations = 0;
4443
int buildDryRunInvocations = 0;
4544
int linkInvocations = 0;
46-
int linkDryRunInvocations = 0;
4745
int hasPackageConfigInvocations = 0;
4846
int packagesWithNativeAssetsInvocations = 0;
4947
BuildModeImpl? lastBuildMode;
@@ -122,8 +120,7 @@ final class FakeFlutterNativeAssetsBuilderResult
122120
implements
123121
native_assets_builder.BuildResult,
124122
native_assets_builder.BuildDryRunResult,
125-
native_assets_builder.LinkResult,
126-
native_assets_builder.LinkDryRunResult {
123+
native_assets_builder.LinkResult {
127124
const FakeFlutterNativeAssetsBuilderResult({
128125
this.assets = const <AssetImpl>[],
129126
this.assetsForLinking = const <String, List<AssetImpl>>{},

packages/flutter_tools/test/general.shard/isolated/hot_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ void main() {
9797
expect(buildRunner.buildInvocations, 0);
9898
expect(buildRunner.buildDryRunInvocations, 0);
9999
expect(buildRunner.linkInvocations, 0);
100-
expect(buildRunner.linkDryRunInvocations, 0);
101100
expect(buildRunner.hasPackageConfigInvocations, 0);
102101
expect(buildRunner.packagesWithNativeAssetsInvocations, 0);
103102
}, overrides: <Type, Generator>{

packages/flutter_tools/test/general.shard/isolated/resident_runner_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ void main() {
8282
expect(buildRunner.buildInvocations, 0);
8383
expect(buildRunner.buildDryRunInvocations, 0);
8484
expect(buildRunner.linkInvocations, 0);
85-
expect(buildRunner.linkDryRunInvocations, 0);
8685
expect(buildRunner.hasPackageConfigInvocations, 0);
8786
expect(buildRunner.packagesWithNativeAssetsInvocations, 0);
8887

0 commit comments

Comments
 (0)