Skip to content

Commit bc78e2c

Browse files
authored
[Impeller] updated todos from opengles golden work (flutter#50218)
followup from flutter/engine#50146 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
1 parent 78d7128 commit bc78e2c

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

impeller/golden_tests/vulkan_screenshotter.mm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,8 @@ CGContextPtr context(
7474
CGImagePtr image(CGBitmapContextCreateImage(context.get()), &CGImageRelease);
7575
FML_CHECK(image);
7676

77-
// TODO(tbd): Perform the flip at the blit stage to avoid this slow
78-
// copy.
77+
// TODO(https://github.com/flutter/flutter/issues/142641): Perform the flip at
78+
// the blit stage to avoid this slow copy.
7979
if (texture->GetYCoordScale() == -1) {
8080
CGContextPtr flipped_context(
8181
CGBitmapContextCreate(

testing/run_tests.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -567,7 +567,8 @@ def make_test(name, flags=None, extra_env=None):
567567
executable_filter,
568568
shuffle_flags + [
569569
'--enable_vulkan_validation',
570-
'--gtest_filter=-*OpenGLES', # TODO(tbd)
570+
# TODO(https://github.com/flutter/flutter/issues/142642): Remove this.
571+
'--gtest_filter=-*OpenGLES',
571572
],
572573
coverage=coverage,
573574
extra_env=extra_env,

0 commit comments

Comments
 (0)