Skip to content

Remove support for 3 deprecated settings #23975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Mar 24, 2025

This change marks these settings and legacy and removes the associated code:

  • SUPPORT_ERRNO
  • EXTRA_EXPORTED_RUNTIME_METHODS
  • DEMANGLE_SUPPORT

These settings have been marked as deprecated for over a year now since the system for settings deprecation was added in #21355.

@sbc100 sbc100 requested review from kripken and dschuff March 24, 2025 22:35
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % comment

These settings have been marked as deprecated for over a year now since
the system for settings deprecation was added in emscripten-core#21355.
@sbc100 sbc100 force-pushed the remove_deprecated_settings branch from 0d22124 to 7774f80 Compare March 25, 2025 17:54
@sbc100 sbc100 enabled auto-merge (squash) March 25, 2025 18:10
@sbc100 sbc100 merged commit 325b7d2 into emscripten-core:main Mar 25, 2025
24 checks passed
@sbc100 sbc100 deleted the remove_deprecated_settings branch March 25, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants