Skip to content

Disable test_fs_readdir_ino_matches_stat_ino on Windows #23234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

dschuff
Copy link
Member

@dschuff dschuff commented Dec 19, 2024

No description provided.

@dschuff dschuff requested review from sbc100 and hoodmane December 19, 2024 19:05
@dschuff
Copy link
Member Author

dschuff commented Dec 19, 2024

On windows, the failing line is

readdir a_ino: 780273, b_ino: 780272
stat    a_ino: 7318349395257329, b_ino: 11821949022627824
Aborted(Assertion failed: a_ino == sta.st_ino, at: C:\b\s\w\ir\x\w\install\emscripten\test\fs\test_fs_readdir_ino_matches_stat_ino.c,58,main)

@sbc100
Copy link
Collaborator

sbc100 commented Dec 19, 2024

I guess inodes are likely to be different on windows. Strange that stat and readdir would differ though.

@sbc100
Copy link
Collaborator

sbc100 commented Dec 19, 2024

Feel free to land this once the test-windows bot passes. No need to wait for the rest.

@dschuff
Copy link
Member Author

dschuff commented Dec 19, 2024

I guess inodes are likely to be different on windows. Strange that stat and readdir would differ though.

yeah it is; I don't know why that would be.

@dschuff dschuff merged commit c4ecb13 into emscripten-core:main Dec 19, 2024
13 of 29 checks passed
@hoodmane
Copy link
Collaborator

Maybe one of them followed the link incorrectly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants