Skip to content

mark test_fs_dev_random as crossplatform #23116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2024
Merged

mark test_fs_dev_random as crossplatform #23116

merged 2 commits into from
Dec 10, 2024

Conversation

dschuff
Copy link
Member

@dschuff dschuff commented Dec 10, 2024

Disable it on Windows. It wasn't running there before #23088

@dschuff
Copy link
Member Author

dschuff commented Dec 10, 2024

This test is failing on Chromium CI https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8729107776427442657/+/u/Emscripten_testsuite__other_/stdout

but the cause is a mysterious OOB error.

@dschuff dschuff marked this pull request as ready for review December 10, 2024 01:55
@dschuff dschuff requested a review from sbc100 December 10, 2024 03:15
@dschuff
Copy link
Member Author

dschuff commented Dec 10, 2024

I'm going to go ahead and land this to unblock the roller.

@dschuff dschuff merged commit d87c1ac into main Dec 10, 2024
28 checks passed
@dschuff dschuff deleted the dev_random branch December 10, 2024 03:15
hedwigz pushed a commit to hedwigz/emscripten that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant