Disable test_fs_enotdir on Windows #23095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be another instance of emscripten-core#8882 where errno values don't match. This could be "fixed" by making the error check a little looser if we care about the behavior of NODERAWFS on Windows. For now just disable to unblock the rollers.
sbc100
reviewed
Dec 6, 2024
|
Going to go ahead and land this to unblock. |
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
This seems to be another instance of emscripten-core#8882 where errno values don't match. This could be "fixed" by making the error check a little looser if we care about the behavior of NODERAWFS on Windows. For now just disable to unblock the rollers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be another instance of #8882 where errno values don't
match. This could be "fixed" by making the error check a little
looser if we care about the behavior of NODERAWFS on Windows.
For now just disable to unblock the rollers.