Fix false positive writability check on cache directory #23049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
em_cache
branch
2 times, most recently
from
8704530 to
7c65e19
Compare
kripken
approved these changes
Dec 3, 2024
sbc100
force-pushed
the
em_cache
branch
3 times, most recently
from
b1013d1 to
32b3595
Compare
We were incorrectly reporting non-existent parent directories as non-writable. This was broken in emscripten-core#22801.
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
…ore#23049) We were incorrectly reporting non-existent parent directories as non-writable. This was broken in emscripten-core#22801.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were incorrectly reporting non-existent parent directories as non-writable.
This was broken in #22801.