Remove cleanup code from stdlib tests. NFC #23003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
When running tests in emscripten there is no requirement to clean up after yourself. The test framework automatically gives each test a clean directory to work in. In fact, cleaning up after yourself like this makes debugging harder because in the failure case you can not longer see the state of the filesystem when test fails. In addition, it meant that all these tests were also relying on and testing `atexit` and `signal` handling, making the tests more complex that less precise. As part of this change I also make sure all these tests could be compiled outside of emscripten (on my desktop linux machine).
sbc100
force-pushed
the
remove_cleanup
branch
from
100903e to
d7ad68b
Compare
kripken
approved these changes
Nov 25, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Dec 5, 2024
- Convert to C. - Move to `test/stdio` This test was originally added in c008b11 and is not specific to C++ cstdio and was the only file in this directory. Also remove the cleanup code. See emscripten-core#23003.
sbc100
added a commit
that referenced
this pull request
Dec 5, 2024
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
- Convert to C. - Move to `test/stdio` This test was originally added in c008b11 and is not specific to C++ cstdio and was the only file in this directory. Also remove the cleanup code. See emscripten-core#23003.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running tests in emscripten there is no requirement to clean up after yourself. The test framework automatically gives each test a clean directory to work in.
In fact, cleaning up after yourself like this makes debugging harder because in the failure case you can no longer see the state of the filesystem at the point of failure.
In addition, it meant that all these tests were also relying on and testing
atexitandsignalhandling, making the tests more complex that less precise.As part of this change I also made sure all these tests could be compiled outside of emscripten (on my desktop linux machine).