Skip to content

Make readlink system call not resolve the link #23000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

hoodmane
Copy link
Collaborator

@hoodmane hoodmane commented Nov 25, 2024

Readlink in linux does not resolve the link, it returns the exact link contents. Resolves #22999.

Readlink in linux does not resolve the link, it returns the exact link contents.
@hoodmane
Copy link
Collaborator Author

@sbc100 test failure looks like it may be a flake?

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! great to see the test simplification!

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how simple this fix is! Thanks.

@sbc100 sbc100 enabled auto-merge (squash) November 26, 2024 21:46
@sbc100 sbc100 merged commit 8da8cb1 into emscripten-core:main Nov 26, 2024
28 checks passed
@hoodmane hoodmane deleted the readlink-noresolve branch December 9, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readlink incorrectly returns fully qualified path
2 participants