Skip to content

Use orientationIndex enum from header #21550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 19, 2024
Merged

Use orientationIndex enum from header #21550

merged 6 commits into from
Mar 19, 2024

Conversation

cwoffenden
Copy link
Contributor

@cwoffenden cwoffenden commented Mar 17, 2024 •
edited
Loading

As suggested in #21428 the enum value was taken from the header.

In the process, since adding to struct_info.json was needed, a fix to the reported path prompting to run gen_struct_info.py was added.

@cwoffenden cwoffenden mentioned this pull request Mar 17, 2024
Merged
@cwoffenden
Copy link
Contributor Author

Failures seem to be down to changes in generated_struct_info64.json not matching the older version.

sbc100
sbc100 reviewed Mar 18, 2024
View reviewed changes
sbc100
sbc100 reviewed Mar 18, 2024
View reviewed changes
@sbc100 sbc100 merged commit 524b94f into emscripten-core:main Mar 19, 2024
@cwoffenden cwoffenden deleted the orientation-tidy-1 branch March 19, 2024 17:03
@cwoffenden
Copy link
Contributor Author

Note to a future me, because this will trip me up again in six months...

 emcc --clear-cache
 ./tools/maint/gen_struct_info.py
 ./tools/maint/gen_struct_info.py --wasm64
 ./tools/maint/gen_sig_info.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwoffenden @sbc100