Skip to content

Avoid __postset for ERRNO_CODES. NFC #20518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2023
Merged

Avoid __postset for ERRNO_CODES. NFC #20518

merged 1 commit into from
Oct 23, 2023

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Oct 23, 2023

We can just use a string literal here.

@sbc100
Avoid __postset for ERRNO_CODES. NFC
9a1e97a 
We can just use a string literal here.
@sbc100 sbc100 requested a review from kripken October 23, 2023 19:16
@sbc100 sbc100 enabled auto-merge (squash) October 23, 2023 19:16
kripken
kripken approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good solution to that problem.

Perhaps we can use it in #20415 too? Though there we only want the quotes when closure will run, actually...

@sbc100 sbc100 merged commit 176035d into emscripten-core:main Oct 23, 2023
@sbc100 sbc100 deleted the errno_codes branch October 23, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @kripken