[test] Fix flakiness in test_pthread_wait32/64_notify #20412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the reason these tests were not flaky on the browser test suite is because the output is not being tested/verified there. |
|
The flakes we are seeing look like this BTW: |
sbc100
force-pushed
the
fix_flakiness
branch
2 times, most recently
from
0578e9d to
cf1f27e
Compare
sbc100
requested review from
kripken
and removed request for
dschuff and
brendandahl
sbc100
force-pushed
the
fix_flakiness
branch
3 times, most recently
from
831ca15 to
fc1fc47
Compare
kripken
reviewed
Oct 10, 2023
| @@ -66,15 +65,14 @@ void* thread_main(void* arg) { | |||
|
|
|||
|
|
|||
| EM_BOOL main_loop(double time, void *userData) { | |||
| if (addr == 1) { | |||
| if (addr == 3) { | |||
| // Burn one second to make sure worker finishes its test. | |||
There was a problem hiding this comment.
This PR seems like an improvement, but as a side note, this part of the test ("burn one second") looks fishy...
There was a problem hiding this comment.
I agree that is pretty nasty.. but its also pre-existing. I looked into trying to fix that but it could be more involved so leaving it for now.
kripken
approved these changes
Oct 10, 2023
Avoid racing between the main thread and the worker by only triggering the main thread to notify once the workers done printing all its messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid racing between the main thread and the worker by only triggering the main thread to notify once the workers done printing all its messages.