Skip to content

[Wasm64] Fix embind with addresses over 4gb #20071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2023
Merged

[Wasm64] Fix embind with addresses over 4gb #20071

merged 1 commit into from
Aug 18, 2023

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Aug 18, 2023

Fixes: #19968

@sbc100 sbc100 requested review from kripken and brendandahl August 18, 2023 02:24
sbc100 added a commit that referenced this pull request Aug 18, 2023
- Convert some malloc tests from C++ for C
- Use @parameterize to split up test_embind.

Split out from #20071
sbc100 added a commit that referenced this pull request Aug 18, 2023
- Convert some malloc tests from C++ for C
- Use @parameterize to split up test_embind.

Split out from #20071
sbc100 added a commit that referenced this pull request Aug 18, 2023
- Convert some malloc tests from C++ for C
- Use @parameterize to split up test_embind.

Split out from #20071
@sbc100 sbc100 force-pushed the embind_4gb branch 3 times, most recently from 661c8b2 to 4c462cc Compare August 18, 2023 16:05
Copy link
Collaborator

@brendandahl brendandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are a number of change unrelated to embind/emval?

@sbc100
Copy link
Collaborator Author

sbc100 commented Aug 18, 2023

Reverted unrelated changes (moved to a followup PR)

sbc100 added a commit that referenced this pull request Aug 18, 2023
- Convert some malloc tests from C++ for C
- Use @parameterize to split up test_embind.

Split out from #20071
Base automatically changed from more_4gb to main August 18, 2023 19:57
@sbc100 sbc100 requested a review from brendandahl August 18, 2023 19:59
@sbc100 sbc100 enabled auto-merge (squash) August 18, 2023 20:59
@sbc100 sbc100 disabled auto-merge August 18, 2023 21:56
@sbc100 sbc100 merged commit 0f83fd4 into main Aug 18, 2023
@sbc100 sbc100 deleted the embind_4gb branch August 18, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embind problems with val::as<T>() in wasm32 with MAXIMUM_MEMORY=4GB
2 participants