Remove makeMalloc utility function. NFC
#19160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
remove_makeMalloc
branch
from
3485869 to
02214c8
Compare
kripken
approved these changes
Apr 11, 2023
sbc100
force-pushed
the
remove_makeMalloc
branch
2 times, most recently
from
25dfdc7 to
a9a1d04
Compare
It seems much safer/cleaner to simply use explicit dependencies on `malloc`. The one function where an optional dependency might be useful is `allocate` since it can operator both with and without `malloc`, but that function is deprecated/legacy. See #19159
sbc100
force-pushed
the
remove_makeMalloc
branch
from
a9a1d04 to
42339e1
Compare
This was referenced Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems much safer/cleaner to simply use explicit dependencies on
malloc. The one function where an optional dependency might be useful isallocatesince it can operator both with and withoutmalloc, but that function is deprecated/legacy.See #19159