Skip to content

Restore xlocale.h compat header. #17111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Restore xlocale.h compat header. #17111

merged 1 commit into from
Jun 1, 2022

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented May 31, 2022

This is a parial revert or #17022 ("Define _LIBCPP_HAS_MUSL_LIBC in
libcxx build")

Alos, add a new test for this header.

@sbc100 sbc100 requested review from kripken and walkingeyerobot May 31, 2022 17:54
Copy link
Collaborator

@walkingeyerobot walkingeyerobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks very much!

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming the test+output files are the same ones as from before

This is a parial revert or #17022 ("Define _LIBCPP_HAS_MUSL_LIBC in
libcxx build")

Alos, add a new test for this header.
@sbc100 sbc100 merged commit 60a1dc1 into main Jun 1, 2022
@sbc100 sbc100 deleted the revert_xlocal branch June 1, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants