[WasmFS] Disable other.test_unlink on Windows #16464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was written to expose some unspecified, niche behavior in Linux's file system implementation, so it's not surprising that it fails on Windows. Disable the test on Windows for now until we can investigate the differences and adapt the test accordingly.
|
Landing TBR to unbreak the rollers. |
|
LGTM, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was written to expose some unspecified, niche behavior in Linux's file
system implementation, so it's not surprising that it fails on Windows. Disable
the test on Windows for now until we can investigate the differences and adapt
the test accordingly.