Run one websockify test on macOS during CI. NFC #16395
Conversation
sbc100
force-pushed
the
websockify_macos
branch
from
f8007e1 to
ee78052
Compare
This requires more consistent running of `pip install`
sbc100
force-pushed
the
websockify_macos
branch
from
ee78052 to
a93090d
Compare
| - run: | ||
| name: run tests | ||
| command: | | ||
| ./tests/runner << parameters.test_targets >> | ||
| $EMSDK_PYTHON ./tools/check_clean.py | ||
| run-tests-linux: |
There was a problem hiding this comment.
why is this called linux? looks like it is very generic, just prepares and then runs tests?
does this overlap with another PR? the prepare-for-tests part looks familiar...
There was a problem hiding this comment.
Yes I have other PR that was trying to do a similar thing on windows: #16378.
But I figured making it work on mac first was a good plan.
There was a problem hiding this comment.
But I figured making it work on mac first was a good plan.
Do you mean Linux?
There was a problem hiding this comment.
Oh, I see. This differentiates the refactored linux steps from the new mac steps.
There was a problem hiding this comment.
No, we already run all the socket tests on linux.. this change just adds the running on one of them on macOS
This requires more consistent running of
pip install