[NFC] Factor out initialization of em_queued_call arguments #15686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first step toward decoupling the logic for proxying work to threads from the logic for creation and dispatch of `em_queued_call` objects, which couple a dynamically typed function pointer with its arguments. Decoupling these pieces will allow for more general proxying that is not required to use the `em_queued_call` mechanism and will simplify the code.
kripken
approved these changes
Dec 1, 2021
sbc100
reviewed
Dec 1, 2021
| static void init_em_queued_call_args(em_queued_call* q, | ||
| EM_FUNC_SIGNATURE sig, | ||
| va_list args) { | ||
| EM_FUNC_SIGNATURE argumentsType = sig & EM_FUNC_SIG_ARGUMENTS_TYPE_MASK; |
There was a problem hiding this comment.
I think you can do q->functionEnum = sig; here too.. in fact maybe just pass func_ptr too and call this init_em_queued_call
There was a problem hiding this comment.
In an upcoming PR I add a function similar to what you suggest that allocates and initializes the full em_queued_call. The reason to bundle the initialization with allocation is that it is much easier to manually initialize a stack-allocated em_queued_call, so an initialization function (except for the args) is not as useful.
mmarczell-graphisoft
pushed a commit
to GRAPHISOFT/emscripten
that referenced
this pull request
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.