Cleanup pthread tests. NFC. #13211
Merged
Cleanup pthread tests. NFC. #13211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is currently broken due to WebAssembly/waterfall#678 |
kleisauke
referenced
this pull request
in kleisauke/emscripten
Jan 8, 2021
kleisauke
force-pushed
the
cleanup-pthread-tests
branch
from
4defe14 to
fe44328
Compare
|
OK, I've rebased this on top of the master branch. Let's see how this behaves in CI now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleanups the
tests/core/pthread/{create,exceptions}.cpptests by:std::atomic<T>, were possible;exit(0);after canceling the main loop;-sEXIT_RUNTIMEfor a true shutdown;Commit kleisauke@4defe14 is unrelated to the above changes, but I thought I could include within this PR as well (since it's a small typo fix).
(this was split from #12963, as requested in #12963 (comment))