test_core.py: remove @no_wasm decorator #12466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Oct 7, 2020
| #else | ||
| MYASSERT(!!strstr(str, "at __Z3bariPcd (page.js"), "Callstack was %s!", str); | ||
| MYASSERT(!!strstr(str, "at __Z3FooIiEvv (page.js"), "Callstack was %s!", str); | ||
| #endif |
There was a problem hiding this comment.
do we not want to eventually fix this so it passes (so a TODO instead of deleting)? and why does this part not pass?
There was a problem hiding this comment.
No, I don't think there is any value in this part of the test. I think this part of the tests was written for the fastcomp days. I'll need to revisit to see exactly why I think that, but basically the backtrace always has demangled symbols in wasm mode... there is no way to get these mangled symbols anymore as far as I know.. because we always put demangled names in the names section.. or none at all.
kripken
approved these changes
Oct 7, 2020
| #else | ||
| MYASSERT(!!strstr(str, "at __Z3bariPcd (page.js"), "Callstack was %s!", str); | ||
| MYASSERT(!!strstr(str, "at __Z3FooIiEvv (page.js"), "Callstack was %s!", str); | ||
| #endif |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #12335