Clean up pthread startup code (NFC) #12308
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two places that pthread workers were initialized, one in a postSet,
and one at the end of postamble. This joins the two into a single
initWorker
method, and moves code to there, which is simpler.
(Also add a missing
initWorker
for minimal runtime, so this is technicallynot NFC for that runtime. Note that there may be more fixes needed there,
this just does the obvious thing for this PR to improve things.)
This will make fixing a race condition in a subsequent PR easier.