Handle both emscripten_longjmp and emscripten_longjmp_jmpbuf #12157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter appears without running wasm-emscripten-finalize)
|
Can you add a comment with TODO to remove the long named version? Why do we even need these at all? |
|
I'm not sure why these exist - probably something with the emscripten-longjmp pass in the backend? cc @aheejin |
|
(Note that regardless of the question of why we have these two names, I think we do want to land this - it will prevent a broken roll when we remove one of the names, no matter if we do that in LLVM or binaryen.) |
sbc100
approved these changes
Sep 10, 2020
kripken
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Sep 11, 2020
Instead of finalize renaming emscripten_longjmp_jmpbuf to emscripten_longjmp, do nothing in finalize. But in the optional --post-emscripten pass, rename it there if both exist, so that we don't end up using two imports (other optimization passes can then remove an unneeded import). Depends on emscripten-core/emscripten#12157 to land first so that emscripten can handle both names, and it is just an optimization to have one or the other. See #3043
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The longer name appears from the wasm backend, and wasm-emscripten-finalize renames
it. Instead, support both, and then we can remove the long name either in LLVM or in
binaryen.
See WebAssembly/binaryen#3043