Skip to content

Remove the asmjs native optimizer #12131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Sep 8, 2020

This is no longer in use since fastcomp removal.

See: #11860

This is no longer in use since fastcomp removal.

See: #11860
@sbc100 sbc100 requested a review from kripken September 8, 2020 20:02
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory we could enable the native optimizer for the small amount of wasm2js usage that could benefit from it. It might be a little faster to run. But it's just a small part of wasm2js compile times (most optimization is done on binaryen) and this is a big simplification, so this looks great.

@sbc100 sbc100 merged commit 8c6ab93 into master Sep 8, 2020
@sbc100 sbc100 deleted the remove_native_optimizer_part2 branch September 8, 2020 20:56
sbc100 added a commit to WebAssembly/waterfall that referenced this pull request Sep 8, 2020
sbc100 added a commit to WebAssembly/waterfall that referenced this pull request Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants