Don't strip debug info in unoptimized builds #12016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to always run wasm-opt's
--strip-debugwhen-gwas notspecified, which would strip out DWARF as well as the Name section.
This changes us to leave it alone. This has no effect on release builds
(
-O1+) and no effect on proper debug builds (-O0 -g), but does havean effect on unoptimized builds (
-O0) without-g, which may now containDWARF or the Name section now, depending on how clang and wasm-ld
were invoked.
Part of reducing unnecessary work after link, and aligning us more
with what LLVM tools normally do, see
WebAssembly/binaryen#3043