Only run --no-exit-runtime when optimizing #11998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Aug 22, 2020
| @@ -711,12 +711,6 @@ LibraryManager.library = { | |||
| atexit__proxy: 'sync', | |||
| atexit__sig: 'iii', | |||
| atexit: function(func, arg) { | |||
| #if ASSERTIONS | |||
| #if EXIT_RUNTIME == 0 | |||
| warnOnce('atexit() called, but EXIT_RUNTIME is not set, so atexits() will not be called. set EXIT_RUNTIME to 1 (see the FAQ)'); | |||
There was a problem hiding this comment.
I'm sure I've seen this warning though... or am I confusing it with another warning about EXIT_RUNTIME being recommened?
There was a problem hiding this comment.
I was thinking if the famous program exited (with status: 0), but EXIT_RUNTIME is not set, so halting execution but not exiting the runtime or preventing further async execution (build with EXIT_RUNTIME=1, if you want a true shutdown) .. which is different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That pass is a pure optimization: it removes calls to
atexitwhen theywould be ignored anyhow (
EXIT_RUNTIME == 0).This removes a warning in
atexit's implementation that was neveractually called before: we used to always run that pass, so if
EXIT_RUNTIME == 0then we never had any calls toatexitanyhow. Now that we only run the pass when optimizing, leaving
that warning would be a noticeable change (and it broke some
tests actually!) so just remove it. With that, this is essentially
NFC except that non-optimized builds may be a little larger
(containing calls to
atexitthat end up doing nothing).Helps WebAssembly/binaryen#3043